Swarm deploy: prune containers and do not detach#250
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the production deployment command to add explicit pruning of stale containers and disable detached mode for better deployment feedback. The changes ensure that old containers are cleaned up automatically and that deployment progress is visible in the console.
Key Changes:
- Modified the
docker stack deploycommand to include--prunefor automatic cleanup of orphaned containers - Added explicit
--detach=falseflag to ensure synchronous deployment with visible output
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
============================================
- Coverage 78.07% 77.22% -0.86%
Complexity 52 52
============================================
Files 16 16
Lines 187 180 -7
============================================
- Hits 146 139 -7
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vjik
approved these changes
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--prunemakes removing unused container that are no longer in the stack.--detach=falsemake the command actually get the output from the Docker Swarm about how actual deployment goes and errors if any. Previously it was existing with success as long as compose file was sent.