Support Windows usage of the echoctl tool - #4
Conversation
|
thanks, doing windows builds was on my todo list, but sort of pushed it back since I don't use it myself, and the actual twrp install was, on the surface at least, linux/macos only. |
| import "golang.org/x/sys/windows" | ||
|
|
||
| // Free is the space left on the filesystem holding path, in bytes. | ||
| func Free(path string) (int64, error) { |
There was a problem hiding this comment.
this is only used on the dot, no? So I'm not sure the point of splitting it off, since on there it would not be windows?
There was a problem hiding this comment.
I think it's mostly because the windows build still used the layout package for embedded build time data like version, etc. it was a very quick compilation wrror, ran into it almost immediately.
There was a problem hiding this comment.
ah makes sense, Free shouldn't be in layout anyway probably. Should just go into dot-side code, like diag. I can move it there after if you want to keep it as-is for now.
There was a problem hiding this comment.
Sounds good - do you need any action from me?
2 participants
Hi! I did a bit of work to make your tool usable for Windows users to ease my own explorations, so I figured I'd contribute it back if you're interested.
The tool basically Just Worked - I only had to implement the free-space check in a Windows-friendly way, and ensure paths that the tool pushed to the device via
adbused Posix-friendly path separators.Everything else is just build infra to ensure publish the Windows binaries as part of your existing release process.
Cheers, this was fun to use on my own Dots :)