Skip to content

Update type.go#98

Open
bhainesva wants to merge 1 commit intoentitiesfrom
strings-nil-check
Open

Update type.go#98
bhainesva wants to merge 1 commit intoentitiesfrom
strings-nil-check

Conversation

@bhainesva
Copy link
Contributor

@bhainesva bhainesva commented Mar 1, 2019

Can we do this

@bhainesva bhainesva requested a review from cdworak March 1, 2019 19:26
@cdworak
Copy link
Contributor

cdworak commented Mar 1, 2019

Per discussion offline, I think if we need to handle a nil then this should return nil rather than []string{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants