Skip to content

chore: update minimatch#604

Merged
benlife5 merged 4 commits intomainfrom
update-minimatch
Feb 24, 2026
Merged

chore: update minimatch#604
benlife5 merged 4 commits intomainfrom
update-minimatch

Conversation

@benlife5
Copy link
Contributor

@benlife5 benlife5 requested a review from a team as a code owner February 23, 2026 20:27
@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

Walkthrough

This pull request updates development and tooling metadata. In packages/pages/package.json the devDependency minimatch is bumped (from ^9.0.3 to ^10.2.2) and the devDependency @types/minimatch is removed. The THIRD-PARTY-NOTICES file is edited to update a listed minimatch version (9.0.3 → 9.0.5). The repository lint-staged configuration is adjusted to exclude THIRD-PARTY-NOTICES from the oxfmt formatter.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the minimatch dependency.
Description check ✅ Passed The description references a JIRA vulnerability issue (VULN-42320), which relates to the minimatch update in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-minimatch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/pages/package.json`:
- Line 103: Remove the redundant `@types/minimatch` entry from lockfiles and
package manifests (it conflicts with minimatch v10's built-in types) and run a
fresh install to update lockfile; then audit imports (e.g., the test file
packages/pages/src/common/src/function/internal/getFunctionFilepaths.test.ts and
any other modules) to ensure minimatch is only imported using ESM-style imports
(import { minimatch }) and not required via CommonJS, and if any CommonJS
consumers remain or you're constrained to CJS, either pin brace-expansion to a
compatible non-ESM version or add a dependency resolution/override to force a
compatible brace-expansion version so minimatch@10 works in your environment.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc4627a and 5abfdd6.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/pages/package.json

asanehisa
asanehisa previously approved these changes Feb 23, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 55: Replace the undocumented negation prefix used in package.json
("!**/THIRD-PARTY-NOTICES") with the documented micromatch extglob form
"!(**/THIRD-PARTY-NOTICES)" in the lint-staged config; update the pattern string
in the package.json entry so lint-staged sees the extglob negation, and verify
that the change in path structure (presence of a slash) does not inadvertently
disable matchBase behavior—if you need basename matching instead of full-path
matching, adjust the pattern accordingly (e.g., remove the slash or use an
alternate glob) to preserve original matching semantics.

In `@THIRD-PARTY-NOTICES`:
- Around line 8722-8725: THIRD-PARTY-NOTICES currently lists minimatch@9.0.5 but
package.json and the lockfile resolve to minimatch@10.2.2; regenerate the
THIRD-PARTY-NOTICES file from the project's lockfile (e.g., package-lock.json /
yarn.lock / pnpm-lock.yaml) or rerun the license-notice generation script used
in this repo so the entry for minimatch (and any other packages) matches the
resolved versions in the lockfile and the package.json specification.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5abfdd6 and 1551211.

📒 Files selected for processing (2)
  • THIRD-PARTY-NOTICES
  • package.json

Copy link
Collaborator

@mkilpatrick mkilpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rabbit comments

@benlife5
Copy link
Contributor Author

minimatch v9.0.5 is bundled because glob is a dependency. The latest version of glob still uses minimatch v9.0.5 so I think glob (and some other packages) will need to update minimatch before the NOTICES file updates. Our direct installation is a devDependency, so it's license info doesn't get written to NOTICES

@benlife5 benlife5 merged commit 119487f into main Feb 24, 2026
21 checks passed
@benlife5 benlife5 deleted the update-minimatch branch February 24, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants