Skip to content

chore(yew-macro): remove orphan html-component-fail.stderr#4140

Merged
Madoshakalaka merged 1 commit intomasterfrom
chore/remove-orphaned-fail-stderr
Apr 19, 2026
Merged

chore(yew-macro): remove orphan html-component-fail.stderr#4140
Madoshakalaka merged 1 commit intomasterfrom
chore/remove-orphaned-fail-stderr

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

The matching .rs file was deleted in #1738, but the .stderr was left behind. The trybuild glob in html_macro_test.rs only picks up *-pass.rs/*-fail.rs, so this file was never consumed.

The matching `.rs` file was deleted in #1738, but the `.stderr` was
left behind. The trybuild glob in html_macro_test.rs only picks up
`*-pass.rs`/`*-fail.rs`, so this file was never consumed.
@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 802e97f):

https://yew-rs-api--pr4140-chore-remove-orphane-zwa0029j.web.app

(expires Sun, 26 Apr 2026 19:32:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
actix_ssr_router 612.824 612.824 0 0.000%
async_clock 100.001 100.001 0 0.000%
axum_ssr_router 612.816 612.816 0 0.000%
boids 163.721 163.721 0 0.000%
communication_child_to_parent 93.428 93.428 0 0.000%
communication_grandchild_with_grandparent 105.423 105.423 0 0.000%
communication_grandparent_to_grandchild 101.773 101.773 0 0.000%
communication_parent_to_child 90.854 90.854 0 0.000%
contexts 105.659 105.659 0 0.000%
counter 85.689 85.689 0 0.000%
counter_functional 87.710 87.710 0 0.000%
dyn_create_destroy_apps 89.581 89.581 0 0.000%
file_upload 99.205 99.205 0 0.000%
function_delayed_input 94.321 94.321 0 0.000%
function_memory_game 169.489 169.489 0 0.000%
function_router 399.024 399.024 0 0.000%
function_todomvc 164.150 164.150 0 0.000%
futures 234.656 234.656 0 0.000%
game_of_life 100.429 100.429 0 0.000%
immutable 258.369 258.369 0 0.000%
inner_html 80.533 80.533 0 0.000%
js_callback 109.242 109.242 0 0.000%
keyed_list 175.892 175.892 0 0.000%
mount_point 83.903 83.903 0 0.000%
nested_list 112.728 112.728 0 0.000%
node_refs 91.424 91.424 0 0.000%
password_strength 1717.397 1717.397 0 0.000%
portals 93.069 93.069 0 0.000%
router 365.757 365.757 0 0.000%
suspense 113.099 113.099 0 0.000%
timer 88.273 88.273 0 0.000%
timer_functional 98.729 98.729 0 0.000%
todomvc 141.283 141.283 0 0.000%
two_apps 85.892 85.892 0 0.000%
web_worker_fib 136.202 136.202 0 0.000%
web_worker_prime 184.594 184.594 0 0.000%
webgl 82.677 82.677 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link
Copy Markdown

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 257.914 258.335 258.124 0.129
Hello World 10 429.317 435.315 431.899 1.957
Function Router 10 36254.719 37903.547 37010.493 632.681
Concurrent Task 10 1005.633 1006.721 1006.270 0.401
Many Providers 10 928.630 990.744 965.385 18.368

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 257.880 265.425 259.238 2.453
Hello World 10 426.321 458.822 432.056 9.839
Function Router 10 36274.580 36662.621 36410.836 142.565
Concurrent Task 10 1005.328 1006.684 1006.070 0.484
Many Providers 10 938.924 1008.566 962.891 18.647

@Madoshakalaka Madoshakalaka marked this pull request as ready for review April 19, 2026 19:48
@Madoshakalaka Madoshakalaka merged commit a259eae into master Apr 19, 2026
40 checks passed
@Madoshakalaka Madoshakalaka deleted the chore/remove-orphaned-fail-stderr branch April 19, 2026 19:50
shan-shaji pushed a commit to shan-shaji/yew that referenced this pull request Apr 19, 2026
…4140)

The matching `.rs` file was deleted in yewstack#1738, but the `.stderr` was
left behind. The trybuild glob in html_macro_test.rs only picks up
`*-pass.rs`/`*-fail.rs`, so this file was never consumed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant