Repository navigation
Remove submodule gitlinks that no .gitmodules ever described - #53
Merged
Merged
Conversation
dev/yeti and dev/yeti-feeds-frontend were recorded in the tree as submodules, but .gitmodules has never existed in this repository's history, so there was nothing to resolve them against. Every checkout failed: fatal: No url found for submodule path 'dev/yeti' in .gitmodules The process '/usr/bin/git' failed with exit code 128 which is why Docker prod test has been red on every branch, including main, before running any of its own steps. Nothing is lost that was not already lost: the recorded revisions were a 2024-06-12 commit on an unmerged branch and a 2024-05-27 one, 205 and several hundred commits behind their mains. dev/init.sh clones both, so the paths are ignored rather than tracked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Docker prod testfails on every branch includingmain, before running any of its own steps:dev/yetianddev/yeti-feeds-frontendare recorded in the tree as submodules (mode160000), but.gitmoduleshas never existed in this repository's history —git log --all -- .gitmodulesis empty. There is nothing to resolve them against.Everything after checkout is
skipped, so a red X on a yeti-docker PR carries no information about that PR. It bit #52.Reproduction
git clone --recurse-submodulesdoes not show it — with no.gitmodulesit skips submodule init silently. The failing command is the oneactions/checkoutruns during its auth-cleanup step:The full command from the CI log —
git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' ..."— also exits 0 on this branch.Change
git rm --cachedon both paths, and gitignore them. The working tree is untouched:dev/init.shclones both, so they are checkouts rather than tracked content.dev/yeti-agentsis ignored too — another checkout people keep there, currently showing as untracked noise.Nothing is lost
The recorded revisions were already meaningless:
dev/yeti84d623be(2024-06-12)longerauthbranch, 205 behindmaindev/yeti-feeds-frontend8319f1c9(2024-05-27)main, ~2 years staleRelationship to #43
#43 removes these same gitlinks as part of a larger move to sibling checkouts, and adds
dev/source-refs.envas a real replacement for the pin. This is the minimal subset, so CI can start being meaningful while #43 takes the time its layout decision needs. It shrinks #43's diff rather than conflicting with it.