Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #106 by propagating the ydb-sqlalchemy library version into the YDB SDK “build info” header via connection arguments, and bumps minimum ydb / ydb-dbapi versions to those that support the feature.
Changes:
- Add
_additional_sdk_headersto dialectcreate_connect_argswithydb-sqlalchemy/<VERSION>. - Update
requirements.txtminimum versions forydbandydb-dbapi.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
ydb_sqlalchemy/sqlalchemy/__init__.py |
Injects the library version into additional SDK headers during connection creation. |
requirements.txt |
Raises minimum YDB SDK/DBAPI versions needed for the new header behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vgvoleg
force-pushed
the
additional_sdk_info
branch
from
1f17f4f to
651077e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #106