Skip to content

making TIndexTabletTest_Data::ShouldReturnBackendInfoForIOForOverloadedTabletActor more stable#6591

Open
qkrorlqr wants to merge 1 commit into
mainfrom
users/qkrorlqr/more-stable-tablet-overload-ut
Open

making TIndexTabletTest_Data::ShouldReturnBackendInfoForIOForOverloadedTabletActor more stable#6591
qkrorlqr wants to merge 1 commit into
mainfrom
users/qkrorlqr/more-stable-tablet-overload-ut

Conversation

@qkrorlqr

Copy link
Copy Markdown
Collaborator

Notes

Decreasing the probability of things like this: https://github-actions-s3.storage.eu-north2.nebius.cloud/ydb-platform/nbs/Nightly-build-(tsan)/29879592736/1/nebius-x86-64-tsan/logs/1/cloud/filestore/libs/storage/tablet/ut/test-results/unittest/chunk3/testing_out_stuff/TIndexTabletTest_Data.ShouldReturnBackendInfoForIOForOverloadedTabletActor128_KB.err

The test used to spend wall time doing read/write-blob ops caused by background ops which could sometimes cause the tablet to just wait without doing anything and without recording cpu cycles so eventually we could end up not recording any overload because of the following event sequence:

  1. lots of WriteData calls - some overload is recorded
  2. heavy bg ops start, the work is mostly done by read/write-blob actors, the tablet just waits
  3. counters are updated - this time no overload is recorded because during step 2 the tablet actor & executor actor were almost idle
  4. the test fails because of no overload

Issue

None

@qkrorlqr qkrorlqr added the filestore Add this label to run only cloud/filestore build and tests on PR label Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 080dcc5ab1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread cloud/filestore/libs/storage/tablet/tablet_ut_data.cpp
@qkrorlqr
qkrorlqr force-pushed the users/qkrorlqr/more-stable-tablet-overload-ut branch from 080dcc5 to 436f56f Compare July 23, 2026 10:53
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5188s): all tests PASSED for commit 436f56f.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4346 4346 0 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filestore Add this label to run only cloud/filestore build and tests on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants