[NBS] Added Mixed Index blocks filter by vladstepanyuk · Pull Request #6568 · ydb-platform/nbs

vladstepanyuk · 2026-07-21T15:53:44Z

Notes

pr with documentation #6577

Issue

#6390

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d049a8aed

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

robot-vibe-db · 2026-07-21T16:02:07Z

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

Major | Medium: Integer division truncation in constructor — if blockCount is not a multiple of blocksPerRange, StartCommitIdsPerRange vector is too small, causing out-of-bounds access — mixed_index_blocks_filter.cpp:7
Minor | High: Duplicate variable range recomputes rangeIndex with a different name and type — mixed_index_blocks_filter.cpp:40
Minor | High: GetMemoryUsage() does not account for RangeIndexToCompactionRangeInfos memory (pending compaction bitmaps) — mixed_index_blocks_filter.cpp:110
Minor | Medium: Unsigned integer overflow in MayHaveBlocksInMixedIndex loop when range.End == Max<ui32>() causes infinite loop — mixed_index_blocks_filter.cpp:15

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

robot-vibe-db · 2026-07-21T16:02:26Z

Full analysis log

Analysis performed by claude, claude-opus-4-6.

github-actions · 2026-07-22T07:30:34Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

vladstepanyuk · 2026-07-22T08:12:46Z

@codex review

github-actions · 2026-07-22T08:16:30Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

github-actions · 2026-07-22T08:21:19Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af876bf28d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-07-22T09:39:06Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1992s): some tests FAILED for commit b540dd3.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6847	6831	0	15	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 22s): all tests PASSED for commit b540dd3.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
34	34	0	0	0	0	0

github-actions · 2026-07-22T13:14:29Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

github-actions · 2026-07-22T13:19:10Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1701s): all tests PASSED for commit f6d5ae2.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6866	6865	0	0	0	1	0

github-actions · 2026-07-22T14:33:57Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

github-actions · 2026-07-22T14:54:50Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

✅ blockstore

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1521s): some tests FAILED for commit 6b842f9.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6864	6862	0	1	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 21s): all tests PASSED for commit 6b842f9.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
42	42	0	0	0	0	0

vladstepanyuk added blockstore Add this label to run only cloud/blockstore build and tests on PR rebase Add this label if you want to rebase your PR for test run need_ai_review labels Jul 21, 2026

robot-vibe-db Bot added ai_review_in_process and removed need_ai_review labels Jul 21, 2026

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread cloud/blockstore/libs/storage/partition/model/mixed_index_blocks_filter.cpp Outdated

Comment thread cloud/blockstore/libs/storage/partition/model/mixed_index_blocks_filter.cpp

Comment thread cloud/blockstore/libs/storage/partition/model/mixed_index_blocks_filter.cpp Outdated

robot-vibe-db Bot reviewed Jul 21, 2026

View reviewed changes

robot-vibe-db Bot added ai_reviewed and removed ai_review_in_process labels Jul 21, 2026

vladstepanyuk added the recheck Add this label to relaunch checks, it will be automatically removed label Jul 22, 2026

github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Jul 22, 2026

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread cloud/blockstore/libs/storage/partition/model/mixed_index_blocks_filter.cpp

vladstepanyuk added the recheck Add this label to relaunch checks, it will be automatically removed label Jul 22, 2026

github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Jul 22, 2026

vladstepanyuk added 6 commits July 22, 2026 14:51

added TMixedBlocksFilter class

45f95c7

corrected issues

5b6f550

added missed files to ya make

a67bbd8

simplify compactions

b8e6892

rm unused struct

cc19a05

adding sorting rangeIndices

6b842f9

vladstepanyuk force-pushed the users/vladstepanyuk/issue-6390/add-mixed-index-blocks-filter-class/0 branch from b578528 to 6b842f9 Compare July 22, 2026 14:51

SvartMetal self-requested a review July 22, 2026 22:26

Uh oh!

Conversation

vladstepanyuk commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Issue

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robot-vibe-db Bot commented Jul 21, 2026

AI Review Summary

Critical issues

Other findings

Uh oh!

robot-vibe-db Bot commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vladstepanyuk commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vladstepanyuk commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading