Limit loadtest file creation with MaxFileCount by szumal · Pull Request #6549 · ydb-platform/nbs

szumal · 2026-07-17T13:41:36Z

Notes

This is a follow up to #6493 where I introduced a DiagnoseFilesystem command. In order to test it, the loadtest should create a known number of files, which currently is unbounded.

Issue

#6208

github-actions · 2026-07-17T13:41:49Z

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3aa57eec04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-17T17:10:24Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 257s): all tests PASSED for commit 54751bc.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1215	1215	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 264s): all tests PASSED for commit 54751bc.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1572	1572	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1154s): all tests PASSED for commit 54751bc.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6831	6830	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4587s): all tests PASSED for commit 54751bc.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
4351	4351	0	0	0	0	0

github-actions · 2026-07-20T13:55:52Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

github-actions · 2026-07-20T14:28:18Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

github-actions · 2026-07-20T15:04:24Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 262s): all tests PASSED for commit 1957b8c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1215	1215	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 271s): all tests PASSED for commit 1957b8c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1572	1572	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1488s): all tests PASSED for commit 1957b8c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6831	6830	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5115s): all tests PASSED for commit 1957b8c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
4351	4351	0	0	0	0	0

github-actions · 2026-07-21T11:51:26Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

github-actions · 2026-07-21T12:08:10Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 266s): all tests PASSED for commit 6c7072d.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1215	1215	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 285s): all tests PASSED for commit 6c7072d.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1572	1572	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1487s): all tests PASSED for commit 6c7072d.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6831	6830	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5068s): all tests PASSED for commit 6c7072d.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
4351	4351	0	0	0	0	0

qkrorlqr · 2026-07-21T15:08:07Z

+
+    // Maximum number of regular files created by this synthetic load test.
+    // Zero means unlimited. Ignored by replay specs.
+    uint64 MaxFileCount = 22;


now this

nbs/cloud/filestore/tools/testing/loadtest/protos/loadtest.proto

Line 40 in 6fb757c

uint64 MaxNodes = 2;

looks redundant

let's delete TIndexLoadSpec::MaxNodes and rename this MaxFileCount parameter to MaxNodes

github-actions · 2026-07-21T15:48:44Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 261s): all tests PASSED for commit fcc1885.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1215	1215	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 277s): all tests PASSED for commit fcc1885.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1572	1572	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1400s): all tests PASSED for commit fcc1885.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
6831	6830	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5143s): all tests PASSED for commit fcc1885.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
4351	4351	0	0	0	0	0

szumal marked this pull request as draft July 17, 2026 13:46

szumal changed the title ~~Limiting loadtest file creation with MaxFileCount~~ Limit loadtest file creation with MaxFileCount Jul 17, 2026

chatgpt-codex-connector Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread cloud/filestore/tools/testing/loadtest/lib/request_replay_grpc.cpp Outdated

Comment thread cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated

szumal self-assigned this Jul 17, 2026

szumal force-pushed the users/szumal/add-max-file-count-to-loadtest branch from ea3cd58 to 8466153 Compare July 17, 2026 15:12

szumal added 2 commits July 17, 2026 17:19

Initial implementation of MaxFileCount

cd117e2

Add an integration test for MaxFileCount

f0fe4ce

szumal force-pushed the users/szumal/add-max-file-count-to-loadtest branch from 8466153 to f0fe4ce Compare July 17, 2026 15:19

szumal added 3 commits July 17, 2026 18:08

Move test to separate dir, use canonical output

53159ef

Do not apply MaxFileCount to request replays

bf1f829

Remove unused dependency

54751bc

szumal marked this pull request as ready for review July 17, 2026 16:26

qkrorlqr added the ok-to-test Label to approve test launch for external members label Jul 17, 2026

github-actions Bot removed the ok-to-test Label to approve test launch for external members label Jul 17, 2026

ruslan-gar requested changes Jul 20, 2026

View reviewed changes

Rename the limiter to CountLimiter

d23c1c5

Linting

2385bba

Applying requested changes

1957b8c

szumal requested a review from ruslan-gar July 20, 2026 15:02

Applying requested changes

ca5b820

Format test result

6c7072d

qkrorlqr reviewed Jul 21, 2026

View reviewed changes

Reuse the MaxNode parameter for all bounded loadtests

fcc1885

Uh oh!

Conversation

szumal commented Jul 17, 2026

Notes

Issue

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qkrorlqr Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading