credential broker: refuse percent-encoded parent traversal - #198
Merged
Conversation
The broker's path allowlist checked literal "../" but not its percent-encoded forms, so an allowed prefix could be escaped with %2e%2e%2f (single- or double-encoded). Decode before checking, reject any path whose decoded form contains a parent traversal, and cover the git smart-HTTP route with the same guard. Regression tests exercise both routes with plain, single-, and double-encoded traversals. Reported in #154 (closes the #125 git-broker finding). Co-authored-by: yassine-ceo <yassine-ceo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the git-broker finding from #125; reported in #154. The path allowlist checked literal
../but not percent-encoded forms (single or double). Decode before checking, reject decoded parent traversals, same guard on the git smart-HTTP route. Tests cover both routes, plain/single/double-encoded. Co-authored with the #154 reporter.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.