Skip to content

Support configured directory service principals - #161

Draft
jaykaycodes wants to merge 2 commits into
yc-software:mainfrom
Ester-Health:codex/service-principals
Draft

Support configured directory service principals#161
jaykaycodes wants to merge 2 commits into
yc-software:mainfrom
Ester-Health:codex/service-principals

Conversation

@jaykaycodes

@jaykaycodes jaykaycodes commented Aug 3, 2026

Copy link
Copy Markdown

Summary

  • add validated DIRECTORY_SERVICE_PRINCIPALS core configuration
  • overlay configured identities without persisting them as surface-owned directory rows
  • preserve configured identities across Slack directory replacement while retaining explicit deactivation
  • prevent canonical/Slack alias collisions and remove identities immediately when configuration is removed

This provides an explicit service-identity path for Slack-less and mixed-surface deployments related to #153 without treating every OIDC login as a directory member.

Verification

  • npm test (3717 tests, 3585 passed, 132 skipped, 0 failed)
  • npm run typecheck
  • npm run lint -- --quiet
  • Prettier check on affected files
  • independent fresh-context review: no findings after two review-driven fixes

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@16francej 16francej added code-pr Code submitted instead of an ADR enhancement New feature or request labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-pr Code submitted instead of an ADR enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants