Skip to content

Fix Docker deployment defaults and admin seeding#24

Open
geokeji wants to merge 5 commits into
yaojingang:mainfrom
geokeji:codex/batch-deploy-fixes
Open

Fix Docker deployment defaults and admin seeding#24
geokeji wants to merge 5 commits into
yaojingang:mainfrom
geokeji:codex/batch-deploy-fixes

Conversation

@geokeji
Copy link
Copy Markdown

@geokeji geokeji commented May 11, 2026

Summary

  • make Docker runtime images and Composer mirror configurable for development and production
  • harden the production compose/deploy flow, including writable Laravel paths, Reverb public settings, proxy headers, and automatic default-admin seeding in the init container
  • add a quick Docker Compose stack and cover the default admin seeder behavior
  • update deployment docs and localized README notes for production admin seeding

Verification

  • git diff --check origin/main..HEAD
  • docker compose config
  • docker compose --env-file .env.prod -f docker-compose.prod.yml config
  • docker compose -f docker-compose.quick.yml config

Notes

  • PHP tests were not run locally because the host machine does not have a php binary installed.

@yaojingang
Copy link
Copy Markdown
Owner

感谢提交 PR,这个方向是有价值的,尤其是 Docker 镜像源可配置、Composer 镜像可配置、生产目录权限处理、quick compose、默认管理员 Seeder 测试这些部分。

不过目前这版暂时不能直接合并,主要有几个问题需要先调整:

  1. 当前 PR 和最新 main 存在冲突,需要先 rebase / merge 最新 main 后重新提交。
  2. 默认管理员初始化逻辑和 main 里已经合入的 AUTO_SEED=true init 容器方案重复了,请基于现有方案做增量修改,不要再改成另一套初始化链路。
  3. .env.prod.example 里出现了具体业务域名 xxx,开源默认配置里不能写死具体域名,需要改回通用占位或通过环境变量配置。
  4. Nginx 里 fastcgi_param HTTPS on; 不建议固定写死,可能影响 HTTP、反向代理、子目录部署等场景。这里应继续基于可信代理和 forwarded headers 处理。
  5. Reverb、镜像源、生产部署脚本这些改动建议拆小一点,避免一个 PR 同时修改太多生产关键路径,后续更容易 review 和验证。
  6. 请补充至少以下验证结果:
    • docker compose config
    • docker compose --env-file .env.prod -f docker-compose.prod.yml config
    • 相关 PHP 测试,尤其是默认管理员 Seeder 测试

建议你基于最新 main 重新整理一版:优先保留“镜像源可配置、权限处理、Seeder 测试、quick compose”这些低风险改动;Reverb / Nginx / 默认管理员初始化相关逻辑请按当前主分支设计重新适配。修复后我们再继续 review,合适的话再合并。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants