Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c094a5c32
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .filter(|change| { | ||
| detect_language(&change.path) | ||
| .map(|language| requested.contains(&language)) | ||
| .unwrap_or(false) | ||
| detect_language(&change.old_path) | ||
| .into_iter() | ||
| .chain(detect_language(&change.new_path)) | ||
| .any(|language| requested.contains(&language)) |
There was a problem hiding this comment.
--no-test-filter
This broader filter now keeps any rename where either old_path or new_path matches the requested language, but the TestFilterMode::All branch in src/main.rs still renders change.added/change.deleted verbatim. In a rename like tests/test_mod.py => src/lib.rs, git diff-stat --lang py --no-test-filter will incorrectly include the Rust additions, and --lang rs --no-test-filter will incorrectly include the Python deletions, so language-scoped stats become wrong whenever a file crosses language boundaries.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f525a4860f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let stats = | ||
| build_test_filtered_stats(&git, &selection, &changes, &langs, cli.test_filter_mode())?; |
There was a problem hiding this comment.
--no-test-filter
Routing TestFilterMode::All through build_test_filtered_stats means git diff-stat --no-test-filter now reads/parses selected Rust and Python sources again instead of just rendering git diff --numstat. That regresses the documented “disable test filtering” behavior: for example, a repo with any tracked .rs file that is not valid UTF-8 will now fail under --no-test-filter because build_whole_test_paths eagerly loads Rust sources, even if that file is unchanged. The old direct-render fast path should stay in place for All so this mode remains a safe fallback.
Useful? React with 👍 / 👎.
1 participant
Summary
js,ts,jsx,tsx,cjs,mjslanguage detection and make the default language scope include all supported languages--testand--no-testusing path and filename conventionsTesting