Repository navigation
feat(postgres): добавить Pagila и разделить CI-проверки SQL-стенда - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
make samples-postgresдля загрузки schema и data;5ba5a57aeb159f75f02aca2432d3c262186d13d3;samples/postgresи исключены из Git;050_load_optional_samples.sh;DB_USER, а schema и data загружаются от его имени;.docker.envбольше не перезаписывается при обновлении.docker.env.example;127.0.0.1;MySQL check— MySQL, World и Sakila;PostgreSQL check— PostgreSQL и Pagila;SQL Lab check— совместный запуск MySQL и PostgreSQL, а также Adminer;actions/checkoutобновлён доv5.Проверки
Локально выполнены:
git diff --check;make init;make config;make check-postgres-access;В GitHub Actions успешно прошли:
MySQL check / mysql-check;PostgreSQL check / postgres-check;SQL Lab check / sql-lab-check.Важно
Обычные команды запуска не скачивают Pagila автоматически.
Для существующего
.docker.envнужно вручную добавить:Для применения Pagila к уже инициализированному PostgreSQL требуется явная команда:
Автоматическое удаление пользовательских data-каталогов не выполняется.