Repository navigation
fix(clone): apply the cloned repository dot config to the same-invocation install - #93
Merged
Merged
Conversation
…tion install A repo committing .config/dot/config.yaml had it ignored during clone: config resolution ran once at CLI startup, before the repo existed on disk, so a zero-touch bootstrap installed with the default layout and mangled the target. After cloning, read the repo config dotfile options and rebuild the manage service used for the install; a broken repo config errors loudly. dot config get/list now resolve with repository priority too, matching every other command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by adversarial verification of a real dotfiles repo bootstrap: a repository committing .config/dot/config.yaml had it completely ignored by dot clone, because config resolution runs once at CLI startup, before the repo exists on disk. A zero-touch bootstrap on a fresh machine therefore installed with default layout options and mangled the target home. After the clone materializes, the service now reads the repo config dotfile options and rebuilds the manage service used for the install; a present-but-broken repo config errors loudly. dot config get/list now also resolve with repository priority, matching manage/status/list/doctor and the documented contract in repository-config.md.