Repository navigation
ci(release): let feature commits bump the minor version before 1.0 - #92
Merged
Merged
Conversation
bump-patch-for-minor-pre-major demoted every feat to a patch bump, so a feature release computed 0.6.7 instead of 0.7.0. bump-minor-pre-major stays; features now bump minor, breaking changes still bump minor not major until 1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump-patch-for-minor-pre-major demoted every feat to a patch bump, so the pending feature release computed 0.6.7 instead of 0.7.0. Removing it lets bump-minor-pre-major do its job: features bump minor, breaking changes still bump minor rather than major until 1.0. The open release PR should retarget to 0.7.0 on merge.