fix: exclude generated explainers mirror from em-dash scan - #412
Merged
Conversation
faircode/_explainers/*.md is a generated copy of explainers/*.md; scanning both reports the same em dash twice under different paths. Add the mirror to ALLOW_PREFIXES, matching the paper/results-frozen/ exclusion pattern.
Contributor
|
@AnayDhawan is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
yakew7
added a commit
that referenced
this pull request
Sep 4, 2026
…n to live numbers CONTRIBUTORS.md was missing nitishchauhan002 (#410, first merged PR) and shauryagangrade (#425, first merged PR) entirely, and AnayDhawan's #412 wasn't reflected in their existing entry - snapshot bumped to cover everything through #425. CHANGELOG.md gets matching "Fixed" entries under the version already shipping (2.2.0), including the ambiguous-JSON follow-up fix from the previous commit. METRICS.md's weekly row and badges, and README's Traction table, updated to live GitHub numbers (stars, forks, contributors, issues closed this week) pulled via `gh`. Countries/social reach left unchanged - no access to site analytics or Instagram/LinkedIn impressions to verify those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #393
faircode/_explainers/*.mdis a generated, package-internal mirror ofexplainers/*.md(byte-identical copies).check_em_dash.py'sALLOW_PREFIXESonly excludedpaper/results-frozen/, so an em dash inexplainers/foo.mdgets reported twice under two different-looking paths for the same root cause.Added
faircode/_explainers/toALLOW_PREFIXES, same pattern as the existingpaper/results-frozen/exclusion.Test plan
python3 scripts/check_em_dash.pypasses locally