Define the base assets path using CMake.#1
Open
3a2l wants to merge 1 commit intoyahiaetman:masterfrom
Open
Conversation
Owner
|
That's a really good idea. |
Author
|
Could perhaps add an option for reading an environment variable
I'm fine with implementing this if you like this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Yahia,
This fixes a bug where the examples will fail to load or run because the paths to assets (shaders, models, etc.) are using relative paths.
I defined a base
ASSETS_DIRusing CMake (for all projects) and concatenated that with the existing strings (minus the "assets" part).I tested a few examples and they seem to work now.
3a2l