Skip to content

skstream-0.3.9 - #1028

Merged
fd00 merged 1 commit into
masterfrom
dorgann/skstream-0.3.9
Nov 16, 2026
Merged

fd00 merged 1 commit into
masterfrom
dorgann/skstream-0.3.9

Conversation

@yacp-dev

@yacp-dev yacp-dev Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor
package skstream
version 0.3.9
tests ⚠️ no tests ran; ⚠️ upstream has tests, not run (test/Makefile.am defines TESTS/check_PROGRAMS)
audit ⚠️ see the report below
❌ NG (1)

Check

check: empty (automake's test suite has no tests) -- see whether upstream has a test suite src_test doesn't reach
check-upstream-tests: upstream has tests that were not run (test/Makefile.am defines TESTS/check_PROGRAMS)

--- end of /cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/log/skstream-0.3.9-1bl5-check.log ---
make[2]: Leaving directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build/test'
/usr/bin/make  check-TESTS
make[2]: Entering directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build/test'
make[3]: Entering directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build/test'
============================================================================
Testsuite summary for skstream 0.3.9
============================================================================
# TOTAL: 0
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build/test'
make[2]: Leaving directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build/test'
make[1]: Leaving directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build/test'
make[1]: Entering directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build'
make[1]: Leaving directory '/cygdrive/d/a/dist/dist/yacp/skstream/skstream-0.3.9-1bl5.x86_64/build'
✅ OK (16)

LICENSE

Recipe: LICENSE="GPL-2.0-or-later" LICENSE_URI="COPYING"
No SPDX-License-Identifier headers in the source
License text COPYING: GPL-2.0
License notice in compiled sources' headers: GPL-2.0-or-later: 9 file(s), e.g. skstream/skaddress.cpp

BUILD_REQUIRES

BUILD_REQUIRES is empty

Dependencies the build didn't find

cppunit (pc): Cygwin has it in cppunit -- not in BUILD_REQUIRES

Build-time downloads

nothing downloaded during the build

Runtime requirements

README lists 6 runtime requirement(s)

CMake config requirements

no CMake package config installed

Recipe

skstream-0.3.9-1bl5.cygport has no BOM
CATEGORY Libs is in data/categories.yml
HOMEPAGE https://github.com/worldforge/skstream answers 200
LICENSE is set (GPL-2.0-or-later)
LICENSE is an expression mksetupini accepts
LICENSE_URI = COPYING is under $S
PATCH_URI, *_REQUIRES and LICENSE are where ports' recipes keep them

Undefined macros

none in 1 compile log(s)

pkg-config

skstream-0.3.pc version 0.3.9, prefix /usr, --libs -lskstream-0.3
skstream-unix-0.3.pc version 0.3.9, prefix (none), --libs (none)
usr/lib/pkgconfig/skstream-0.3.pc names nothing of the build tree
usr/lib/pkgconfig/skstream-unix-0.3.pc names nothing of the build tree

AppStream

nothing in the legacy path usr/share/appdata

CMake files

nothing in usr/share/cmake

FHS paths

only FHS directories at the top of $D and of usr/

etc/defaults

nothing installed in /etc

Duplicate files

none of the 6 file(s) in usr/share/doc/skstream has a copy elsewhere

man3

no manual page of a C function outside the -devel package

Package size

all 5 tarball(s) in dist/skstream under GitHub's 100 MiB file limit, the largest skstream-debuginfo/skstream-debuginfo-0.3.9-1bl5-x86_64.tar.xz (0.1 MiB)

Run: https://github.com/yacp-dev/dist/actions/runs/43778170735

To publish this build to gh-pages:

gh workflow run publish.yml -f artifact_id=14187352449 --repo yacp-dev/dist

@yacp-dev
yacp-dev Bot force-pushed the dorgann/skstream-0.3.9 branch 4 times, most recently from 8e950dc to 0609903 Compare November 15, 2026 23:52
@yacp-dev
yacp-dev Bot force-pushed the dorgann/skstream-0.3.9 branch from e41daba to 0ba74d7 Compare November 16, 2026 00:08
@fd00

fd00 commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

cygport check result

Run: https://github.com/yacp-dev/dist/actions/runs/43776715953

9 passed, 2 failed, 1 hung (12 of the 22 registered tests started; the other 10 never ran). The failures are not fixed in this PR: cppunit is deliberately left out of BUILD_REQUIRES, so upstream's test runner is not built and cygport check reports an empty suite.

Still failing

Test Symptom
tcpskstreamtest::testConstructor_2 assertion
tcpskstreamtest::testOpen assertion
tcpskstreamtest::testOpenNonblock no result; killed by timeout 60 (exit 124)

Cause A (testConstructor_2, testOpen): these connect to 127.0.0.1 port 7 and expect an echo service. The CI runner has none.

  • Confirmed: both tests fail in the per-test run above. The source (test/childskstreamtest.h) asserts is_open() after connecting to port 7, with the message "Check that echo service is running on local machine".
  • Not confirmed: that the connection is actually refused on the runner (the errno was not printed).

Cause B (testOpenNonblock): the test spins in while(!skstream->isReady()) ++waitcount; with no exit condition, so it never returns when the connection does not become ready.

  • Confirmed: it is the last test the runner prints before the timeout, in a runner that lists each test by name. With the stock runner, cygport check timed out after 10 minutes at the same point.
  • Not confirmed: why isReady() never returns true on Cygwin (for example, a non-blocking connect to a closed port never reporting writable).

Not examined

  • udpskstreamtest, rawskstreamtest, tcpskservertest, udpskservertest (10 tests): they never ran, because the runner hangs before them. The server tests use port 8888 on localhost and may pass.
  • The 9 tests that passed were not examined further.

Not patched

No source or test change was made. Cause A is the CI environment, since upstream's tests assume an echo service. Cause B would need a patch to the test, and Cause A would still leave the suite failing. Adding cppunit as it is would make every build wait 10 minutes for the timeout, so it is left out until the tests can run unattended.

@fd00
fd00 merged commit 9e07db3 into master Nov 16, 2026
@fd00
fd00 deleted the dorgann/skstream-0.3.9 branch November 16, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant