Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The remaining documentation nit is non-blocking.
Review effort: Lite
Findings: None
What changed in this PR
Updates getDevices filters, connector metadata, documentation, tests, and package version to 0.15.0.
Changes:
- Adds device filters and connector response notes.
- Updates catalog, CLI guidance, workflows, and pagination documentation.
- Adds catalog and query serialization tests.
- Bumps release metadata to 0.15.0.
| File | Summary |
|---|---|
tests/skills-edge-params-guidance.test.ts |
Validates documentation guidance. |
tests/endpoints.test.ts |
Verifies catalog metadata. |
tests/cli.test.ts |
Tests query serialization. |
src/workflows/flow-catalog.ts |
Updates pagination guidance. |
src/api-catalog/public-endpoints.json |
Adds endpoint filters and connector notes. |
skills/xyte-cli/references/flow-recipes.md |
Updates flow recipes. |
skills/xyte-cli/references/endpoints.md |
Documents filters and connector fields. |
skills/xyte-cli/data/public-endpoints.json |
Synchronizes shipped catalog data. |
README.md |
Updates device query guidance. |
package.json |
Bumps version to 0.15.0. |
package-lock.json |
Synchronizes package metadata. |
docs/flows/agent-ops.md |
Updates pagination instructions. |
docs/commands.md |
Adds filter examples and guidance. |
CHANGELOG.md |
Documents the release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ariel-greenfeld
left a comment
There was a problem hiding this comment.
AI: Deep review (planner + 3 lenses + verifier). The catalog/docs match hub server#9482: filters, enums, 422 messages, per_page max 100, next_page, and the connector block (UUID ids for c2c and edge, null for native). Internal CLI getDevices calls only send allowed params. 186/186 tests pass on head.
Blocking: the branch conflicts with main (1 Mid). Also 3 Low nits.
Reminder: xyte-mcp builds its catalog from the hub Bruno collection, so it needs a regeneration PR once server#9482 merges.
…inute (review 4153771956)
AI: All items addressed and replied to; re-requesting review.
ariel-greenfeld
left a comment
There was a problem hiding this comment.
AI: Re-review of 5dfcedd. All 4 threads from my last review are fixed and resolved: main is merged with the getHistories entries under [0.15.0], the status / effective_status tip, the fragile has_next_page check is gone, and the "status filters can lag up to a minute" note is in the catalog, the skills copy and endpoints.md. No new findings. Typecheck passes and 1249 tests pass locally.
Not approving yet: the CI "security" job is red. npm audit reports 5 dependency vulnerabilities (fast-uri, brace-expansion, ...). This PR did not cause them (its lockfile change is only the version bump), but please get that check green, here or in a separate PR, and I will approve.
ariel-greenfeld
left a comment
There was a problem hiding this comment.
AI: Approved. All threads are fixed and there are no new findings. The red security job (npm audit on existing dependencies) is not caused by this PR, so it does not block it. Please handle it separately.
xyte-cli catalog update for DEV-6922 (https://linear.app/xyte/issue/DEV-6922):
organization.devices.getDevicesgainsname,status,effective_status,model_id,connection_method,connector_id; notes cover the 422 on unsupported params and the newconnectorblock on device objects. Exposure stays raw-catalog. Version 0.14.0 → 0.15.0.Merge after the hub PR (xyte-io/server, same branch).