Skip to content

DEV-6922: getDevices filters and connector block - #79

Merged
borisd merged 5 commits into
mainfrom
dev-6922-getdevices-add-filters-name-status-model-connector-and
Oct 7, 2026
Merged

borisd merged 5 commits into
mainfrom
dev-6922-getdevices-add-filters-name-status-model-connector-and

Conversation

@borisd

@borisd borisd commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

xyte-cli catalog update for DEV-6922 (https://linear.app/xyte/issue/DEV-6922): organization.devices.getDevices gains name, status, effective_status, model_id, connection_method, connector_id; notes cover the 422 on unsupported params and the new connector block on device objects. Exposure stays raw-catalog. Version 0.14.0 → 0.15.0.

Merge after the hub PR (xyte-io/server, same branch).

Copilot AI lite review requested due to automatic review settings September 25, 2026 08:28
@borisd borisd added the pending-auto-review Queued for the AI auto-review loop (pr-auto-review) label Sep 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The remaining documentation nit is non-blocking.

Review effort: Lite
Findings: None

What changed in this PR

Updates getDevices filters, connector metadata, documentation, tests, and package version to 0.15.0.

Changes:

  • Adds device filters and connector response notes.
  • Updates catalog, CLI guidance, workflows, and pagination documentation.
  • Adds catalog and query serialization tests.
  • Bumps release metadata to 0.15.0.
File Summary
tests/​skills-edge-params-guidance.test.ts Validates documentation guidance.
tests/​endpoints.test.ts Verifies catalog metadata.
tests/​cli.test.ts Tests query serialization.
src/​workflows/​flow-catalog.ts Updates pagination guidance.
src/​api-catalog/​public-endpoints.json Adds endpoint filters and connector notes.
skills/​xyte-cli/​references/​flow-recipes.md Updates flow recipes.
skills/​xyte-cli/​references/​endpoints.md Documents filters and connector fields.
skills/​xyte-cli/​data/​public-endpoints.json Synchronizes shipped catalog data.
README.md Updates device query guidance.
package.json Bumps version to 0.15.0.
package-lock.json Synchronizes package metadata.
docs/​flows/​agent-ops.md Updates pagination instructions.
docs/​commands.md Adds filter examples and guidance.
CHANGELOG.md Documents the release.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@borisd borisd added awaiting-reviewer Waiting on the reviewer: a new PR, or the author has answered every comment and removed pending-auto-review Queued for the AI auto-review loop (pr-auto-review) labels Sep 25, 2026
@ariel-greenfeld ariel-greenfeld self-assigned this Sep 30, 2026

@ariel-greenfeld ariel-greenfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI: Deep review (planner + 3 lenses + verifier). The catalog/docs match hub server#9482: filters, enums, 422 messages, per_page max 100, next_page, and the connector block (UUID ids for c2c and edge, null for native). Internal CLI getDevices calls only send allowed params. 186/186 tests pass on head.

Blocking: the branch conflicts with main (1 Mid). Also 3 Low nits.

Reminder: xyte-mcp builds its catalog from the hub Bruno collection, so it needs a regeneration PR once server#9482 merges.

Comment thread CHANGELOG.md
Comment thread CHANGELOG.md Outdated
Comment thread tests/skills-edge-params-guidance.test.ts Outdated
Comment thread src/api-catalog/public-endpoints.json Outdated
@ariel-greenfeld ariel-greenfeld added review-required Reviewer left comments the author must address awaiting-author Waiting on the author: the reviewer left comments to address and removed awaiting-reviewer Waiting on the reviewer: a new PR, or the author has answered every comment labels Oct 1, 2026
@borisd

borisd commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

AI: Merged main and fixed all four threads (f731ffa, 5215a77, de40e0a, 5dfcedd). The xyte-mcp catalog regeneration is noted as follow-up work for after server#9482 merges.

@borisd
borisd dismissed ariel-greenfeld’s stale review October 1, 2026 20:06

AI: All items addressed and replied to; re-requesting review.

@borisd
borisd requested a review from ariel-greenfeld October 1, 2026 20:06
@borisd borisd added review-replied Author has answered every review comment awaiting-reviewer Waiting on the reviewer: a new PR, or the author has answered every comment and removed review-required Reviewer left comments the author must address awaiting-author Waiting on the author: the reviewer left comments to address labels Oct 1, 2026

@ariel-greenfeld ariel-greenfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI: Re-review of 5dfcedd. All 4 threads from my last review are fixed and resolved: main is merged with the getHistories entries under [0.15.0], the status / effective_status tip, the fragile has_next_page check is gone, and the "status filters can lag up to a minute" note is in the catalog, the skills copy and endpoints.md. No new findings. Typecheck passes and 1249 tests pass locally.

Not approving yet: the CI "security" job is red. npm audit reports 5 dependency vulnerabilities (fast-uri, brace-expansion, ...). This PR did not cause them (its lockfile change is only the version bump), but please get that check green, here or in a separate PR, and I will approve.

@ariel-greenfeld ariel-greenfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI: Approved. All threads are fixed and there are no new findings. The red security job (npm audit on existing dependencies) is not caused by this PR, so it does not block it. Please handle it separately.

@ariel-greenfeld ariel-greenfeld removed review-replied Author has answered every review comment awaiting-reviewer Waiting on the reviewer: a new PR, or the author has answered every comment labels Oct 6, 2026
@borisd
borisd merged commit 99015fe into main Oct 7, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants