Preserve P4 state in multi-hook request chains - #5
Draft
xylophonez wants to merge 1 commit into
Draft
xylophonez wants to merge 1 commit into
xylophonez wants to merge 1 commit into
Conversation
xylophonez
force-pushed
the
fix/p4-multi-hook-edge
branch
from
August 10, 2026 14:15
92e38cc to
de30921
Compare
xylophonez
changed the base branch from
review-base/hb-7135fd
to
review-base/hb-edge-20260810
August 10, 2026 14:15
xylophonez
force-pushed
the
fix/p4-multi-hook-edge
branch
3 times, most recently
from
August 10, 2026 14:23
80be3ea to
17584d4
Compare
… hooks request/3 returned a fresh map on every success path, dropping any fields carried on the hook request. A handler ordered after p4 then receives an incomplete request and may resolve against the wrong target. balance/3 matched a single handler from hb_hook:find, so /~p4@1.0/balance returned 500 on any node with more than one request hook. It now selects the p4 handler from the list by its ledger-device.
xylophonez
force-pushed
the
fix/p4-multi-hook-edge
branch
from
August 10, 2026 16:42
17584d4 to
e958625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves fields already carried by the P4 request hook and selects the P4 handler from a multi-hook request chain by its
ledger-device. Includes a real-node regression that places P4 between pass-through and observer hooks.Scope: one existing device file; no
dev_metachanges.Validation:
rebar3 device test -m dev_p4— 4/4 passed. The repository-wide suite is currently blocked on currentedgeby the unchangedhb_beamrnative driver failing withopen_error -10.