Skip to content

Declare the core library sources that two lang test tasks read - #780

Merged
lagergren merged 1 commit into
masterfrom
lagergren/lang-test-inputs
Nov 18, 2026
Merged

lagergren merged 1 commit into
masterfrom
lagergren/lang-test-inputs

Conversation

@lagergren

@lagergren lagergren commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Three lang tests read sources under lib_ecstasy/src/main/x that their test tasks don't declare:

  • LanguageModelTest and DslPowerShowcaseTest in lang/dsl;
  • LspIntegrationTest in lang/lsp-server, which opens Boolean.x, Exception.x and Closeable.x.

After a change to such a source, Gradle could reuse an old result, from the task history or from the build cache. Each test task now declares the directory.

Checked

I added a comment to Boolean.x and ran :lang:dsl:test :lang:lsp-server:test.

:lang:dsl:test :lang:lsp-server:test
master UP-TO-DATE ran
this PR ran ran

On master, lsp-server ran only because the compiler stamps each ecstasy.xtc with the time of the compile, so its compiled test modules change anyway. Once the compiler's output depends only on its input (#778), it would stay up to date too. So this should go in before #778, and before CI keeps the build cache (#781).

spotlessCheck is clean with the lang build included.

@lagergren
lagergren marked this pull request as ready for review November 18, 2026 11:22
LanguageModelTest and DslPowerShowcaseTest in lang/dsl, and
LspIntegrationTest in lang/lsp-server, read sources under
lib_ecstasy/src/main/x that their test tasks did not declare. After a
change to such a source, :lang:dsl:test stayed UP-TO-DATE (checked with a
comment added to Boolean.x), and its result could come back from the build
cache. :lang:lsp-server:test ran again only because the compiler stamps
each ecstasy.xtc with the time of the compile, which changes its compiled
test modules; once the compiler's output depends only on its input, it
would stay up to date as well.
@lagergren
lagergren force-pushed the lagergren/lang-test-inputs branch from 6b09661 to dfb72d5 Compare November 18, 2026 11:22
@lagergren
lagergren merged commit 154398e into master Nov 18, 2026
1 check passed
@lagergren
lagergren deleted the lagergren/lang-test-inputs branch November 18, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant