Repository navigation
Declare the core library sources that two lang test tasks read - #780
Merged
Merged
Conversation
This was referenced Nov 18, 2026
lagergren
marked this pull request as ready for review
November 18, 2026 11:22
LanguageModelTest and DslPowerShowcaseTest in lang/dsl, and LspIntegrationTest in lang/lsp-server, read sources under lib_ecstasy/src/main/x that their test tasks did not declare. After a change to such a source, :lang:dsl:test stayed UP-TO-DATE (checked with a comment added to Boolean.x), and its result could come back from the build cache. :lang:lsp-server:test ran again only because the compiler stamps each ecstasy.xtc with the time of the compile, which changes its compiled test modules; once the compiler's output depends only on its input, it would stay up to date as well.
lagergren
force-pushed
the
lagergren/lang-test-inputs
branch
from
November 18, 2026 11:22
6b09661 to
dfb72d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three lang tests read sources under
lib_ecstasy/src/main/xthat their test tasks don't declare:LanguageModelTestandDslPowerShowcaseTestinlang/dsl;LspIntegrationTestinlang/lsp-server, which opensBoolean.x,Exception.xandCloseable.x.After a change to such a source, Gradle could reuse an old result, from the task history or from the build cache. Each test task now declares the directory.
Checked
I added a comment to
Boolean.xand ran:lang:dsl:test :lang:lsp-server:test.:lang:dsl:test:lang:lsp-server:testOn master,
lsp-serverran only because the compiler stamps eachecstasy.xtcwith the time of the compile, so its compiled test modules change anyway. Once the compiler's output depends only on its input (#778), it would stay up to date too. So this should go in before #778, and before CI keeps the build cache (#781).spotlessCheckis clean with the lang build included.