Repository navigation
Conversation
lagergren
marked this pull request as ready for review
November 18, 2026 09:15
ModuleStructure.getDescription(), which toString() uses, checked the source directory instead of the timestamp before printing the timestamp. A module with a timestamp but no source directory, such as one compiled from a source with no file, was described as "timestamp=none". A module with a source directory but no timestamp made it throw a NullPointerException.
lagergren
force-pushed
the
lagergren/module-description-timestamp
branch
from
November 18, 2026 11:41
3477651 to
87e2284
Compare
Contributor
Author
|
Superseded by #778, which rewrites the same lines in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped into this when recompiling in the LSP. There are modules without source directories, temporarily and I ran into this. The ModuleStructure has checked the source directory instead of the timestamp before printing the timestamp since it was written in 2021. In practice in the known existing XTC ecosystem, we haven't bumped into this since nothing has created this kind of modules.
This is obviously a cut and paste typo, so we should just merge it.
--
ModuleStructure.getDescription(), whichtoString()uses, has checked the source directory instead of the timestamp before printing the timestamp, since both were added in 019524e (2021).timestamp=none.ModuleCompilercompiles from a string.NullPointerException.setTimestamp(null)allows such a module, though.Testing
FileStructureTestandModuleStructureTestpass, andspotlessCheckis clean.