Skip to content

Upgrade Gradle to 9.8.0 - #25

Merged
lagergren merged 3 commits into
masterfrom
gradle-9.8.0-upgrade
Oct 1, 2026
Merged

lagergren merged 3 commits into
masterfrom
gradle-9.8.0-upgrade

Conversation

@lagergren

@lagergren lagergren commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Updates the Gradle wrapper from 9.7.1 to 9.8.0, following the same steps as #20/#21. It also fixes the build for the current XTC plugin snapshot, which master no longer builds with.

Gradle 9.8.0

  • gradle/wrapper/: distribution URL bumped to gradle-9.8.0-bin.zip. Wrapper regenerated with ./gradlew wrapper --gradle-version 9.8.0 --distribution-type bin, run twice. The jar's SHA-256 matches the published 9.8.0 wrapper checksum. gradlew.bat picks up Gradle 9.8's Windows start-script changes; gradlew is unchanged.
  • Dockerfile: builder image bumped from gradle:9.7.1-jdk25 to gradle:9.8.0-jdk25 (tag verified on Docker Hub).
  • gradle.properties: adds org.gradle.tooling.parallel=true. Gradle 9.8 deprecates letting org.gradle.parallel=true implicitly enable parallel Tooling API model building, and Gradle 10 makes it an error. The warning only appears during IDE sync, never in a CLI build. I reproduced it by fetching project models through the Tooling API, and setting the property explicitly removes it. true keeps today's behavior.

I went through the rest of the 9.7 → 9.8 upgrade guide: configuration-time process execution, enabling the build cache from build logic, StartParameter, signing, attribute types, Copy/Sync destinationDir overrides, task logging listeners, Kotlin object state in the configuration cache, and toolchain paths. None of these apply to this build.

XTC plugin resource change (not caused by Gradle 9.8)

The 0.4.4-SNAPSHOT plugin now includes xtclang/xvm#651. Its processXtcResources copies the source set's resources into its own output, and compileXtc reads that output. Master's last CI run (Sept 27) still had :welcome:processXtcResources NO-SOURCE. Today, master on Gradle 9.7.1 fails:

Task ':welcome:processXtcResources' uses this output of task ':welcome:buildWebapp' without declaring an explicit or implicit dependency.

webapp-conventions only made Java's processResources depend on buildWebapp. It now does the same for processXtcResources. That task copies the webapp/ srcDir, including the webapp/build output that welcome serves via @StaticContent("/", /build), so the ordering is needed for correctness, not only to satisfy validation.

CI: Docker image build on master only

The docker job had no condition, so it built the image on every pull request. It now runs only when github.ref == 'refs/heads/master' (master pushes and manual dispatch on master). The master-only gating described in #20 never actually landed in the workflow. On pull requests the job is skipped, which GitHub reports as a passing required check.

Verification

  • ./gradlew clean, then ./gradlew build installDist :welcome:runXtc --stacktrace --console=plain --warning-mode=all --max-workers=1 --no-build-cache --no-daemon: BUILD SUCCESSFUL. All 57 xunit suites pass, with no failures or errors. No deprecation warnings and no problems reported.
  • The welcome module (welcome.xtc, 246 KB) embeds the Vite bundle.
  • Tooling API model fetch (IDE-sync equivalent) with --warning-mode=all: no deprecation warnings.
  • actionlint .github/workflows/ci.yml passes. All actions are already on their latest major versions.

The Docker image build was not run locally (the local Podman socket is unusable, as in #20). Before the CI gating commit, this PR's "Docker image build" job built the image with gradle:9.8.0-jdk25 and passed.

- gradle/wrapper: distributionUrl bumped to 9.8.0; wrapper jar and gradlew.bat
  regenerated by `./gradlew wrapper --gradle-version 9.8.0 --distribution-type bin`
  (run twice). gradlew is unchanged.
- Dockerfile: builder image pinned to gradle:9.8.0-jdk25.
- gradle.properties: set org.gradle.tooling.parallel=true explicitly. Gradle 9.8
  deprecates deriving Tooling API (IDE sync) model-building parallelism from
  org.gradle.parallel, and Gradle 10 makes it an error. true keeps the current
  behavior.
The XTC plugin (0.4.4-SNAPSHOT, xtclang/xvm#651) now copies the main source
set's resources, including the webapp/ srcDir, in processXtcResources with an
output separate from Java's processResources. Only processResources depended on
buildWebapp, so Gradle failed validation: processXtcResources consumed the
outputs of buildWebapp and npmInstall without a dependency. It also risked
compiling welcome with a stale or missing webapp/build, which @staticcontent
serves.
The docker job had no condition, so every pull request built the image.
Gate it on refs/heads/master (master pushes and manual dispatch on master).
The master-only gating described in #20 never landed in the workflow.
@lagergren
lagergren merged commit 60610fa into master Oct 1, 2026
2 checks passed
@lagergren
lagergren deleted the gradle-9.8.0-upgrade branch October 1, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant