Skip to content

Add the vendor SDKs to the hpm and mspm0 images - #2

Merged
Jiu-xiao merged 1 commit into
mainfrom
feat/vendor-sdks
Oct 5, 2026
Merged

Jiu-xiao merged 1 commit into
mainfrom
feat/vendor-sdks

Conversation

@Jiu-xiao

@Jiu-xiao Jiu-xiao commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

The HPM and MSPM0 BSPs build with the vendor SDK outside the repository; with the SDKs in the images, CI and local Docker builds need no SDK download.

  • hpm: HPM SDK v1.13.0 at /opt/hpm_sdk/v1.13.0, HPM_SDK_BASE set; GNURISCV_TOOLCHAIN_PATH set to the toolchain root.
  • mspm0: own build context mspm0/ (was an alias of stm32): the stm32 image content plus MSPM0 SDK mspm0_sdk_2_11_00_07 (source/ and .metadata/ only) at /opt/ti/mspm0_sdk_2_11_00_07 and SysConfig 1.28.1 at /opt/ti/sysconfig_1.28.1, with MSPM0_SDK_INSTALL_DIR and SYSCONFIG_TOOL set. The publish workflow builds docker-image-mspm0 from ./mspm0.
  • README updated.

Image size (compressed): hpm 1.43 -> 1.63 GB, mspm0 0.99 -> 1.33 GB (SysConfig is most of it).

Verified locally: with nothing but the source mounted, bsp-hpm5301evklite (debug-flash-xip, against SDK v1.13.0) and bsp-mspm0g3507-mini (debug, SysConfig run by CMake) build in the new images; sysconfig_cli.sh --version prints 1.28.1+4785.

Note: mspm0/Dockerfile repeats the stm32 Dockerfile, so changes to the shared part have to be made in both.

Summary by Sourcery

Bundle the HPM and MSPM0 vendor SDKs and build tools into their Docker images so BSP builds no longer require external SDK downloads.

New Features:

  • Add the HPM SDK v1.13.0 and required toolchain environment variables to the HPM build image.
  • Provide a dedicated MSPM0 build image containing the MSPM0 SDK, SysConfig 1.28.1, and the existing STM32 build tooling.

Enhancements:

  • Update image documentation to describe the bundled SDKs and configuration paths.

CI:

  • Publish the MSPM0 image from its dedicated Docker build context.

@sourcery-ai

sourcery-ai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Sorry @Jiu-xiao, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 4 days and 16 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Reviewer's Guide

The PR adds versioned HPM and MSPM0 vendor SDKs directly to their Docker images, configures the environment variables required by the BSPs and SysConfig, introduces a dedicated MSPM0 build context, updates publishing to use it, and documents the resulting image capabilities.

Sequence diagram for publishing the dedicated MSPM0 image

sequenceDiagram
    participant Workflow as Publish workflow
    participant Context as mspm0 build context
    participant Image as mspm0 image
    participant Build as MSPM0 BSP build
    Workflow->>Context: docker build
    Context->>Image: Install GNU Arm toolchain and starm-clang
    Context->>Image: Clone MSPM0 SDK
    Context->>Image: Install SysConfig
    Workflow->>Image: Publish docker-image-mspm0
    Build->>Image: Read MSPM0_SDK_INSTALL_DIR
    Build->>Image: Run SYSCONFIG_TOOL
Loading

File-Level Changes

Change Details Files
Bundle the HPM SDK and expose the toolchain and SDK paths expected by HPM BSP discovery.
  • Pin and shallow-clone HPM SDK v1.13.0 into /opt/hpm_sdk/v1.13.0.
  • Set HPM_SDK_BASE and GNURISCV_TOOLCHAIN_PATH, and validate the SDK CMake package and RISC-V tools.
hpm/Dockerfile
Create a dedicated MSPM0 image containing the shared STM32 build dependencies plus the MSPM0 SDK and SysConfig tooling.
  • Duplicate the STM32 image setup for the new mspm0 build context.
  • Sparse-check out only the MSPM0 SDK source/ and .metadata/ directories under /opt/ti/mspm0_sdk_2_11_00_07.
  • Install SysConfig 1.28.1 build 4785 under /opt/ti/sysconfig_1.28.1 and validate its CLI.
  • Set MSPM0_SDK_INSTALL_DIR and SYSCONFIG_TOOL for BSP/CMake discovery.
mspm0/Dockerfile
Publish the MSPM0 image from its dedicated Docker build context.
  • Change the publish matrix context for docker-image-mspm0 from ./stm32 to ./mspm0.
.github/workflows/docker-publish.yml
Document the SDK contents and environment variables now available in the HPM and MSPM0 images.
  • Update image descriptions with SDK versions, installation paths, and discovery variables.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant