Threads and events #42
Conversation
…ons on command line
|
That's a big pull request! thanks for your work. Since github says "This pull request cannot be automatically merged." and you have done a lot of changes without much commit messages i have to review all the commits and cherry pick what's I understand / think it looks nice. Some changes looks like more a personal preference of yours than general issue, like changing default behaviour in 1869fd4 . If there is a chance that you can pick the fixes for real issues in smaller batches in other pull request it'll be helpful. It'll take time to review all these stuff. |
|
With benefit of hindsight, the batch/interactive default behavior change in 1869fd4 was unnecessary -- a simple start-up wrapper in bash would have sufficed. But that change points to a larger issue. You see, I needed to apply Bootchart to a wide variety of post-boot scenarios, and on fine time-scales. For such purposes, the 'batch' mode soon proved unhelpful, and in the later patches I dropped maintenance and testing of 'batch' mode altogether in favor of 'interactive'. You will also see many cosmetic changes, mostly forced by the new applications of the tool. If you're unable to take more than cherry-picked bug fixes, a scan of the first 20-40 patches might find all the fixes you can use. I've already pushed all bug fixes proper as early in the stack as was practical (with the help of some quilt scripting). |
Change timeline expansion/contraction zoom factor from 1.5× to 1.1× for smoother, more precise control when adjusting the time scale. Adapted from xrmx/bootchart#42 (PATCH 004/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Add bounds checking to prevent division by zero when rendering charts with constant values (where data_range[1] == data_range[0]). Adapted from xrmx/bootchart#42 (PATCH 006/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Set line width to 0 before filling charts to prevent the stroke from extending beyond the intended fill area, eliminating visual artifacts at chart boundaries. Adapted from xrmx/bootchart#42 (PATCH 008/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Change default window size from fixed 750x550 to 95% of screen dimensions for better utilization of available screen space. Increase xscale from 3.0 to 5.0 for the full tree view to compensate for the larger window, preventing content from appearing too zoomed in. This makes the default view more comfortable, equivalent to zooming out about 2-3 clicks from the previous default with the larger window. Adapted from xrmx/bootchart#42 (PATCH 018/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Change timeline expansion/contraction zoom factor from 1.5× to 1.1× for smoother, more precise control when adjusting the time scale. Adapted from xrmx/bootchart#42 (PATCH 004/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Add bounds checking to prevent division by zero when rendering charts with constant values (where data_range[1] == data_range[0]). Adapted from xrmx/bootchart#42 (PATCH 006/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Set line width to 0 before filling charts to prevent the stroke from extending beyond the intended fill area, eliminating visual artifacts at chart boundaries. Adapted from xrmx/bootchart#42 (PATCH 008/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Change default window size from fixed 750x550 to 95% of screen dimensions for better utilization of available screen space. Increase xscale from 3.0 to 5.0 for the full tree view to compensate for the larger window, preventing content from appearing too zoomed in. This makes the default view more comfortable, equivalent to zooming out about 2-3 clicks from the previous default with the larger window. Adapted from xrmx/bootchart#42 (PATCH 018/182) Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
2 participants
This fixes a number of arithmetic bugs in the viewer, and extends functionality in various ways.
The two main extensions are:
I've rebased to as recent a commit on mainline as was possible with moderate effort.
Backward-compatibility with the bootchart.tgz format from standard distro collectors is preserved -- tested with Ubuntu.