ci(python-sdk): run on every PR so the required check never hangs#97
Merged
Conversation
The `ruff + pyright + pytest` job is a required status check, but its `paths:` filter meant it reported no status on PRs that don't touch sdk/python — leaving non-SDK PRs stuck on "Expected — Waiting for status to be reported" forever. Drop the filter so the workflow always runs and always reports, matching test/typecheck/build (~1 min with uv caching). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
@basilebong think for now thats a good idea, its does not consumes too much CI time so it should be fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ruff + pyright + pytestjob is a required branch-protection check, but the workflow was scoped with anon.*.pathsfilter tosdk/python/**. On any PR that doesn't touch the SDK the workflow never fires, so the required check never reports a status and the PR sits on "Expected — Waiting for status to be reported" forever. This branch is the live example: it changes onlypnpm-*files, and the check was stuck.A workflow-level
paths:filter and a required status check are fundamentally incompatible: "required" means the check must report before merge, and a path-filtered workflow reports nothing when it doesn't match. The absence is the block.This drops the filter so the workflow always runs and always reports — green in ~1 min on non-SDK PRs (uv caches the interpreter + wheel set), red only when the SDK actually breaks. It now matches
test/typecheck/build, the repo's three other gates, none of which path-filter. The header comment is rewritten to document the why so the filter doesn't get re-added.How to verify
sdk/python/**files, yetruff + pyright + pytestshould now run and pass instead of hanging.sdk/python/still runs the full suite — confirm it fails on a deliberate lint/type error.Notes
ruff + pyright + pytest, the job name) is unchanged.sdk/pythonchanged. That is the cost of keeping it a reliable required gate; the alternative (un-requiring it) would let a broken SDK merge silently.