Updated ruff to v0.16 - #283
Draft
MitchellAV wants to merge 46 commits into
Draft
MitchellAV wants to merge 46 commits into
MitchellAV wants to merge 46 commits into
Conversation
…lop-bax-extension
…ents are referenced in the other extensions
…nd new BAX algorithm implementation
…ated pre-commit hook
…tly more default rules which would inflate PR
…er list of generators
…tion to be alphabetical
…l need to be fixed
MitchellAV
marked this pull request as ready for review
September 15, 2026 18:23
Collaborator
|
Is the intention that this is merged after the BAX PR? |
MitchellAV
marked this pull request as draft
September 16, 2026 18:31
Collaborator
Author
|
@roussel-ryan Moved back to Draft PR for clarity. Requires BAX PR to be merged first, as it was the starting point for this PR |
Collaborator
|
@MitchellAV bax pr has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff increment from v0.15 -> v0.16 adds new default rules https://astral.sh/blog/ruff-v0.16.0
"Ruff now enables 413 rules by default, up from 59 in previous versions."
Entire codebase has been updated and notable exceptions have explanations with the following format
# noqa: <RUFF_ERROR_CODE> - <REASON FOR EXCEPTION>.There are many new rules which will result in higher code quality but may cause growing pains when going forward with future contributions.
One in particular is BLE001 - blind-except. Occasionally there are valid reasons to catch a
BaseExceptionhowever, it is best to handle those on a case-by-case basis by including# noqa: BLE001 - <Explanation of reason BaseException would be valid>Branch requires #275 to be merged first, as it was a starting point and would be easier to review this PR and the ruff changes.