Allow unixtime-style timestamp extraction#30
Conversation
rsommer
force-pushed
the
allow_unix_timestamp_scanning
branch
2 times, most recently
from
358b367 to
1060e30
Compare
rsommer
force-pushed
the
allow_unix_timestamp_scanning
branch
from
7b6b962 to
e4dfae5
Compare
|
Are there plans to still merge this? |
|
We would also be interested in this feature. @xolox Is this repo still maintained? |
| timestamps from filenames. ``PATTERN`` is expected to be a Python compatible | ||
| regular expression that must define the named capture groups 'year', | ||
| 'month' and 'day' and may define 'hour', 'minute' and 'second'." | ||
| regular expression that must define a named capture group 'unixtime' or the |
There was a problem hiding this comment.
@rsommer can you provide better documentations or an example of how to use this new unixtime capture group? I had to read the test case to understand it. There is a section lower in the docs containing some Regex examples, Supported configuration options. That would be a good spot for more elaboration.
There was a problem hiding this comment.
I added a short example to the README file, hope that helps - otherwise this seems to be abandoned, since the original pull request was untouched for over a year :(
There was a problem hiding this comment.
I, too, used to think "no commits in a year! oh no, it's abandoned," as if the author of an open-source project owed me, a random internet visitor, something, anything at all.
If it helps, think of the project as "finished" instead, or "in hobby mode."
Yes, making the GitHub repo read-only or updating the README are helpful signals about the authors' intent to accept PRs, but authors of free, open source software are under no obligation to do that, either.
Some backup solutions prefer using UNIX timestamps for tagging backup files or directories. In order to enable the rotation of such files/directories some extra handling is added to enable scanning for UNIX timestamps in file- or directory-names.
rsommer
force-pushed
the
allow_unix_timestamp_scanning
branch
from
e4dfae5 to
d775f3c
Compare
|
I assume you've worked around this, after all this time, but I published a docker image (here) of my fork (here), which includes your PR. I am not planning to maintain anything in pypi as it's outside my use case, but hopefully this is useful to someone. https://hub.docker.com/repository/docker/aroberts/rotate-backups |
6 participants
Some backup solutions prefer using UNIX timestamps for tagging backup files or directories. In order to enable the rotation of such files/directories some extra handling is added to enable scanning for UNIX timestamps in file- or directory-names.