added wan and cpe-service state in metadata

[nlrcomcast]

RDKB-64737 : Connectivity status metadata over Webpa

[codecov]

Codecov Report

❌ Patch coverage is 93.20388% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.58%. Comparing base (9326f2c) to head (4370022).

Files with missing lines	Patch %	Lines
tests/test_packMetaData.c	89.47%	1 Missing and 21 partials ⚠️
src/upstream_rbus.c	81.25%	1 Missing and 5 partials ⚠️
src/upstream.c	91.30%	2 Missing and 2 partials ⚠️
tests/test_upstream_rbus.c	97.43%	1 Missing and 3 partials ⚠️
src/config.c	94.54%	0 Missing and 3 partials ⚠️
tests/test_config.c	98.41%	0 Missing and 1 partial ⚠️
tests/test_upstream.c	95.23%	0 Missing and 1 partial ⚠️
tests/test_upstream_sock.c	95.65%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   80.35%   81.58%   +1.22%     
==========================================
  Files          58       60       +2     
  Lines       11307    11924     +617     
  Branches     1115     1172      +57     
==========================================
+ Hits         9086     9728     +642     
+ Misses       1787     1721      -66     
- Partials      434      475      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Adds WAN state and CPE service state into Parodus metadata (for WebPA connectivity status reporting), including RBUS subscription support and persistence of CPE service state across process restarts.

Changes:

• Extend upstream metadata packing to include wan-state and cpe-service-state, and update metadata on relevant events.
• Add RBUS WAN state subscription/handler logic and integrate it into startup.
• Add/extend unit tests and CMake test targets to cover RBUS handling, metadata packing, and persisted CPE service state.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/upstream.c	Increases metadata field count, adds CPE service state extraction and metadata mutex.
src/upstream.h	Exposes new metadata mutex APIs and RBUS WAN-state APIs via header changes.
src/upstream_rbus.c	Adds WAN state subscription + handler and updates metadata on subscribe/event callbacks.
src/config.c	Implements read/write of persisted CPE service state and sets defaults.
src/config.h	Adds metadata keys and config struct fields for WAN/CPE service state and persistence path.
src/connection.c	Ensures metadata repack is mutex-protected after successful connection.
src/main.c	Calls WAN state subscription during startup when RBUS is enabled.
src/ParodusInternal.h	Introduces PARODUS_FREE macro used by new RBUS code path.
tests/CMakeLists.txt	Adds new test_packMetaData and test_upstream_rbus targets.
tests/test_packMetaData.c	New CUnit tests for metadata packing/unpacking and CPE service state parsing.
tests/test_upstream_rbus.c	New cmocka tests for RBUS subscribe/handlers and WAN failover handler behavior.
tests/test_upstream.c	Adds stub for new persistence writer to keep upstream unit test linking.
tests/test_upstream_sock.c	Adds stub for new persistence writer to keep upstream sock unit test linking.
tests/test_config.c	Adds tests for persisted CPE service state read/write and default restore behavior.
tests/test_connection.c	Adds metadata mutex mocks needed by connection tests.
tests/test_conn_interface.c	Adds metadata mutex mocks needed by conn interface tests.

Comments suppressed due to low confidence (2)

src/upstream.h:68

• extractCpeServiceState is defined as a non-static function in upstream.c and is called from tests/test_packMetaData.c, but it is not declared in upstream.h. With modern C compilers (C99+), calling an undeclared function is an error (or at least a warning that may be treated as error). Please add a prototype in the public header (or make it static and avoid calling it cross-TU in tests).

void packMetaData();
void lock_metadata_mutex(void);
void unlock_metadata_mutex(void);
void *handle_upstream();
void *processUpstreamMessage();
void registerRBUSlistener();
int getDeviceId(char **device_id, size_t *device_id_len);
int sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size);
void getServiceNameAndSendResponse(wrp_msg_t *msg, void **msg_bytes, size_t msg_size);
void createUpstreamRetrieveMsg(wrp_msg_t *message, wrp_msg_t **retrieve_msg);
void set_global_UpStreamMsgQ(UpStreamMsg * UpStreamQ);
#ifdef WAN_FAILOVER_SUPPORTED
int subscribeCurrentActiveInterfaceEvent();
#endif
int subscribeWanStateEvent();
void wanStateEventHandler(rbusHandle_t handle, rbusEvent_t const* event, rbusEventSubscription_t* subscription);
UpStreamMsg * get_global_UpStreamMsgQ(void);
pthread_cond_t *get_global_nano_con(void);
pthread_mutex_t *get_global_nano_mut(void);
void clear_metadata();

src/upstream.c:126

• packMetaData() overwrites the global metadataPack pointer on every call, but it doesn't free the previous buffer first. With the new WAN/CPE state updates calling packMetaData() on each change, this can turn into an unbounded memory growth if wrp_pack_metadata allocates a fresh buffer each time (as the tests imply by freeing metadataPack). Consider freeing the old metadataPack (and resetting metaPackSize) before repacking, under the same metadata mutex.

void packMetaData()
{
    char boot_time[256]={'\0'};
    //Pack the metadata initially to reuse for every upstream msg sending to server
    ParodusPrint("-------------- Packing metadata ----------------\n");
    sprintf(boot_time, "%d", get_parodus_cfg()->boot_time);
    struct data meta_pack[METADATA_COUNT] = {
            {HW_MODELNAME, get_parodus_cfg()->hw_model},
            {HW_SERIALNUMBER, get_parodus_cfg()->hw_serial_number},
            {HW_MANUFACTURER, get_parodus_cfg()->hw_manufacturer},
            {HW_DEVICEMAC, get_parodus_cfg()->hw_mac},
            {HW_LAST_REBOOT_REASON, get_parodus_cfg()->hw_last_reboot_reason},
            {FIRMWARE_NAME , get_parodus_cfg()->fw_name},
            {BOOT_TIME, boot_time},
            {LAST_RECONNECT_REASON, get_global_reconnect_reason()},
            {WEBPA_PROTOCOL, get_parodus_cfg()->webpa_protocol},
            {WEBPA_UUID,get_parodus_cfg()->webpa_uuid},
            {WEBPA_INTERFACE, getWebpaInterface()},
            {PARTNER_ID, get_parodus_cfg()->partner_id},
            {WAN_STATE, get_parodus_cfg()->wan_state},
            {CPE_SERVICE_STATE, get_parodus_cfg()->cpe_service_state}
        };
    const data_t metapack = {METADATA_COUNT, meta_pack};

    metaPackSize = wrp_pack_metadata( &metapack , &metadataPack );

    if (metaPackSize > 0) 
    {
	    ParodusInfo("metadata encoding is successful with size %zu\n", metaPackSize);
    }
    else
    {
	    ParodusError("Failed to encode metadata\n");
    }
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

src/upstream.c:116

• packMetaData() is now called on WAN/CPE state changes, so it may run multiple times over the process lifetime. It currently overwrites the global metadataPack pointer on each wrp_pack_metadata call without explicitly releasing/resetting the previous buffer. If wrp_pack_metadata does not free/reuse the incoming *data buffer, this will leak memory. To make ownership unambiguous and safe, free the old metadataPack (and set it to NULL / reset metaPackSize) before repacking, under the metadata mutex.

            {CPE_SERVICE_STATE, get_parodus_cfg()->cpe_service_state}
        };
    const data_t metapack = {METADATA_COUNT, meta_pack};

    metaPackSize = wrp_pack_metadata( &metapack , &metadataPack );