fix: resolve golangci-lint issues#191
Open
schmidtw wants to merge 1 commit into
Open
Conversation
- Disable staticcheck ST1005 rule in golangci config - Fix bodyclose warning by properly handling response body in LoadContent - Suppress gosec G101 warnings for test fixture PEM keys
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 94.90% 94.57% -0.33%
==========================================
Files 16 16
Lines 863 867 +4
==========================================
+ Hits 819 820 +1
- Misses 30 32 +2
- Partials 14 15 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johnabass
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loader.goby properly handling HTTP response body cleanup in error paths and LoadContent methodparser_test.go(not real credentials)All golangci-lint issues now resolved (0 issues).