Repository navigation
fix: prevent crashes when LINE Keystore initialization fails - #227
Open
saseungmin wants to merge 1 commit into
Open
saseungmin wants to merge 1 commit into
saseungmin wants to merge 1 commit into
Conversation
Use LINE Android SDK 5.13.0 to include the upstream exception guards for background encryptor initialization and login token persistence. Confidence: high Scope-risk: narrow Tested: TypeScript build, lint, Prettier, Android release AAR build, SDK 5.13.0 dependency resolution, published SDK exception guard Not-tested: Login and Keystore failure reproduction on physical devices Related: line/line-sdk-android#190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent Android crashes caused by LINE SDK Keystore failures
🔄 Type of change:
✏️ Description:
LINE Android SDK 5.12.0 can crash the host app when Android Keystore key generation fails during background encryptor initialization.
The exception escapes from
EncryptorHolder$EncryptorInitializationTask.run():Upgrade
com.linecorp.linesdk:linesdkfrom5.12.0to5.13.0to include the upstream crash fix.The updated SDK catches background initialization exceptions and returns a login error when token persistence fails, allowing the app to handle the failure without crashing.
References:
🎥 Screen record:
Not applicable — native dependency update.
📌 Notes:
✔️ Tasks:
5.13.0.5.13.0in the example app's release runtime dependencies.:xmartlabs_react-native-line:assembleRelease.