Draft
Conversation
This change introduces pre-generated `parser.c` and `parser.h` files into the source tree and adds a manual mechanism to regenerate them. - Added a `yacc-wrapper` script to ensure Bison runs from the project root. This guarantees that `#line` directives in generated files use relative paths, keeping the source tree sanitized and portable. - Added the initial version of the generated `parser.c` and `parser.h` to allow out-of-the-box compilation without a yacc dependency. - Added the meson option `enable-parser-generation` (enabled by default) to choose between auto-generated and pre-generated parser files. - Implemented the `src/xkbcomp/update-parser` custom target (not built by default) to allow developers to manually sync the pre-generated parser files after a `parser.y` update. This approach prevents “Bison lock-in” while maintaining the ability to update the grammar as needed.
- Ensure pre-generated parser files work everywhere. - Ensure pre-generated parser files update works on Linux. For some reason the Windows CI fails on the same task and I could not figure out why, so I removed it.
Meson 1.11.0 has a bug that prevents the build.
wismill
force-pushed
the
build/manual-parser-files-regeneration-debug-meson-issue
branch
2 times, most recently
from
51d95e8 to
f7fbf10
Compare
- Does not build with meson 1.11.0 - Does not run subdir target src/xkbcomp/update-parser
wismill
force-pushed
the
build/manual-parser-files-regeneration-debug-meson-issue
branch
from
f7fbf10 to
3cfa85a
Compare
This was referenced Apr 14, 2026
wismill
force-pushed
the
build/manual-parser-files-regeneration-debug-meson-issue
branch
2 times, most recently
from
93306ca to
389b4be
Compare
wismill
force-pushed
the
build/manual-parser-files-regeneration-debug-meson-issue
branch
from
389b4be to
856bab0
Compare
wismill
force-pushed
the
build/manual-parser-files-regeneration-debug-meson-issue
branch
from
d785c4f to
c6cffc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Same as #1003, but dedicated to debug meson issues on Windows)