[Based on #2143] cabi: preserve debug variable homes#2148
Open
cpunion wants to merge 8 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cpunion
force-pushed
the
codex/dwarf-cabi-metadata
branch
from
July 22, 2026 10:11
b2266d8 to
1401649
Compare
cpunion
marked this pull request as ready for review
July 22, 2026 14:12
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
cpunion
force-pushed
the
codex/dwarf-cabi-metadata
branch
from
July 23, 2026 05:08
1401649 to
05b43c0
Compare
This was referenced Jul 23, 2026
cpunion
force-pushed
the
codex/dwarf-cabi-metadata
branch
from
July 24, 2026 08:14
05b43c0 to
688e810
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2143.
Problem
LLGo currently disables optimized C ABI lowering whenever DWARF is enabled. The lowering replaces a source parameter's stack home with its ABI storage, but its selective operand rewrite does not update LLVM debug records. Enabling the lowering as-is can therefore leave
dbg.declareattached to stale storage.The dependency on #2143 is required by the end-to-end path. On latest
main, the focused operand-rewrite test passes, but the realabi2+ DWARF large-aggregate test crashes while LLVM emits the object. With #2143's DWARF-safe optimization pipeline, the same test completes on both supported validation platforms.Changes
dbg.declare/load operandstest/goprobe in DWARF-enabledabi2modeThe change remains inside the existing C ABI transformer; no debug-specific ABI representation or target exception is introduced.
Verification
internal/cabiandinternal/buildpackage tests; realTestLargeArrayReturnDWARFpasses in 15.10sTestLargeArrayReturnDWARFpass in 15.31sUbuntu validation used 2 CPUs, an 8 GiB memory limit with no swap, and 512 PIDs.