debug: preserve defer locations under full LTO#2144
Closed
cpunion wants to merge 1 commit into
Closed
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cpunion
force-pushed
the
codex/dwarf-lto-debugloc
branch
from
July 22, 2026 08:25
e631213 to
577cda3
Compare
cpunion
marked this pull request as ready for review
July 22, 2026 09:19
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
Consolidated into #2143, which now contains the defer-call debug-location preservation and its LTO regression coverage. Closing this redundant PR; no code is being merged to main by this action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Conditional defer lowering splits the function entry block with a fresh LLVM builder. In a function carrying DWARF, that builder does not inherit the Go source location that triggered defer setup, so synthesized calls such as
GetThreadDefer,AllocU,SetThreadDefer, andRethrowhave no!dbgattachment.Normal native links may accept that IR, but full LTO verifies the combined debug-bearing module and aborts with
inlinable function call in a function with debug info must have a !dbg location.Changes
DebugLocto the synthetic builder when the function has debug metadataThe LTO tests disable LLGo's package cache so #2119's cold/warm metadata issue cannot hide or reintroduce this verifier failure.
Fixes #2118.
Verification
ssatests on macOSUbuntu validation used 2 CPUs, a 15 GiB memory limit, and 512 PIDs.