Revert "cltest: share one go-build cache across captured runs"#2045
Closed
cpunion wants to merge 1 commit into
Closed
Revert "cltest: share one go-build cache across captured runs"#2045cpunion wants to merge 1 commit into
cpunion wants to merge 1 commit into
Conversation
This reverts commit 4d90875.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Closing: the revert does not cure the failure family — its own CI shows the mac coverage job dying anyway (internal/cabi SIGKILLed by the kernel at peak co-residency of the four heavy test binaries on a 7GB runner), i.e. the cache sharing only changed the failure mode, not the cause. Investigation continues into a suspected compiler-side memory growth (post-backbone same-suite peak doubled 5.0GB -> 9.9GB in a controlled 16GB sandbox); the fix will come as a new PR, with #2044's one-suite-per-VM split as the structural companion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the #2035 cache sharing. The causal matrix from this week's investigation:
Same-spec local runs (16GB cgroup) rule out memory (9.9GB peak) and disk (~4GB); the remaining mechanism is platform-level: the per-test fresh cache forced go-loader re-typechecking between llgo compile bursts — a natural stagger. Sharing removed it, the four heavy packages' clang/lld bursts aligned into sustained saturation, and the runner agent starves until GitHub reclaims the VM ("runner has received a shutdown signal").
This revert restores the stagger and unblocks main and the seven stage-5 leaf PRs immediately, at the cost of the measured speedup (mac -30%, ubuntu -43%). #2044 (one heavy suite per VM) is the structural fix that makes the sharing safe again — sharing can be re-landed after it.
🤖 Generated with Claude Code