fix: load balancer admits through its pool instead of passing everything - #56
Merged
Merged
Conversation
passthru skipped capacity, instances and queueLimit, so an lb had no ceiling. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@nawazish2 is attempting to deploy a commit to the whoarrryou's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Checked all five lb presets, none of them move. LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
An
lbnow takes the engine's defaultservepath, socapacity,instancesandqueueLimitgo through ordinary slot and queue discipline. Closes #52.Why
onAdmitreturnedpassthru, which left admission before either check ran. A balancer sized for two concurrent calls carried ~3000 rps,waitingstayed 0, and an autoscaler writinginstancesmoved a number that bound nothing.The inspector already said the pool was real. The engine now matches that.
Verification
client(3000 rps) -> lb -> service(64 slots x 8), lbserviceMs: 5, 30 simulated seconds. Ceiling iscapacity * instances * (1000 / serviceMs).Before (
passthru):After (
serve):This changes behaviour for every design with an lb in it. Default lb sizing (256 slots at 0.5ms) still sits at ~512k rps, so existing presets stay under 2% errors.
bun run test— 914/914 tests passbun run typecheckandbun run lintpassbun run buildpassesMade with Cursor