prevent unsupported quest notification modal during Discord startup - #20
prevent unsupported quest notification modal during Discord startup#20griffinsectio wants to merge 3 commits into
Conversation
…ported quest notification modal
griffinsectio
changed the title
griffinsectio
changed the title
| const quests = [...this._questsStore.quests.values()] | ||
|
|
||
| for (const q of quests) { | ||
| if (!this.isQuestSupported(q)) this._unsupportedQuests.add(q.id); | ||
| } | ||
|
|
||
| const quest = quests.find(x => |
There was a problem hiding this comment.
i mean ur one ok. what u do is check at the start that quest is supported or not..
But i was thinking instead of checking maybe save on config file.
|
u did another commit.. lemme check it |
| ); | ||
|
|
||
| if (this._questsStore && quest) { | ||
| if (this._questsStore && quest && this.isQuestSupported(quest)) { |
There was a problem hiding this comment.
but notification still keep gonna spawn
|
first one was ok 2nd one idk Did u test it? |
|
Maybe it will be better if i make an option on settings to turn off or on notification for unsupported quest. Coz some ppl might want to get notification for any orbs quest |
|
I encountered an issue with my first commit, the plugin won't show the modal when launching the quest for the first time despite the task type being unsupported. The second commit meant to fix this issue. Unfortunately, I was unable to test it out myself and a quest of the unsupported type has now gone expired. |
its ok i am also waiting for activity quest. |
2 participants
In response to #19, which indicate that the plugin will badger the user with a modal which inform that the quest is unsupported. To fix this and improve user experience, I propose to add a loop during plugin initiation that will validate whether a quest is supported by the plugin.