Skip to content

CI: Use native ERT JUnit Reporting#659

Merged
xenodium merged 2 commits into
xenodium:mainfrom
phairoh:ci/native-ert-junit
Jun 17, 2026
Merged

CI: Use native ERT JUnit Reporting#659
xenodium merged 2 commits into
xenodium:mainfrom
phairoh:ci/native-ert-junit

Conversation

@phairoh

@phairoh phairoh commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I originally couldn't get native JUnit reporting to produce a file, so I fell back to ert-junit, which is unmaintained and crashes when a test errors, so test-results.xml was never generated on those runs. As it turns out native JUnit was fine all along, I just wasn't setting the output name via ert-load-file-name (the EMACS_TEST_JUNIT_REPORT env var enables it but doesn't control the filename). This PR drops ert-junit and uses the built-in reporter.

Also, in test-report.yml, dorny/test-reporter@v3 defaults use-actions-summary: true, which doesn't attach the test report to the commit so you have to go digging for it. Setting it to false fixes this. NOTE: this will only take effect once it's on main.

What Passing tests will look like when you click on the checkbox next to the commit:
screenshot-20260617-152239

Failing tests:
screenshot-20260617-153349

Checklist

  • I agree to communicate (PR description and comments) with the author myself (not AI-generated).
  • I've reviewed all code in PR myself and will vouch for its quality.
  • I've read and followed the Contributing guidelines.
  • I've filed a feature request/discussion for a new feature.
  • I'm making visual changes, so I'm including screenshots so you can view and discuss.
  • I've added tests where applicable.
  • I've updated documentation where necessary.
  • I've run M-x checkdoc and M-x byte-compile-file.

@xenodium xenodium left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thank you for looking into it.

@xenodium xenodium merged commit 66afc57 into xenodium:main Jun 17, 2026
1 check passed
@phairoh phairoh deleted the ci/native-ert-junit branch June 17, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants