Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

added password encrypt/decrypt stubs, recursive frame/iframe searches us... - #122

Open
Jaison Guglielmi (jguglielmi) wants to merge 1 commit into
xebia:masterfrom
jguglielmi:OASISBranch
Open

added password encrypt/decrypt stubs, recursive frame/iframe searches us...#122
Jaison Guglielmi (jguglielmi) wants to merge 1 commit into
xebia:masterfrom
jguglielmi:OASISBranch

Conversation

@jguglielmi

Copy link
Copy Markdown

Added encrypt/decrypt stubs, recursive frame search capabilities (no more need for selectFrame) and contextMenu support.

@raboof

Copy link
Copy Markdown
Contributor

A shame about all the whitespace changes - I added #147 to address that separately

@raboof

Copy link
Copy Markdown
Contributor

Does searchAllFrames impact performance? It seems to make things a bit more complicated.

@raboof

Copy link
Copy Markdown
Contributor

Where is encryptString actually used? Could we move this to a separate fixture?

@raboof

Copy link
Copy Markdown
Contributor

It would be nice to have a example/test demonstrating the added features

@jguglielmi

Copy link
Copy Markdown
Author

It is a recursive call, but I hardly noticed anything.
On Jun 28, 2015 4:59 PM, "Arnout Engelen" notifications@github.com wrote:

Does searchAllFrames impact performance? It seems to make things a bit
more complicated.


Reply to this email directly or view it on GitHub
#122 (comment).

@jguglielmi

Copy link
Copy Markdown
Author

Sure. It is used within an OASIS REST call. There is also a decrypt as well.
On Jun 28, 2015 4:59 PM, "Arnout Engelen" notifications@github.com wrote:

Where is encryptString actually used? Could we move this to a separate
fixture?


Reply to this email directly or view it on GitHub
#122 (comment).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the encryption/decryption methods should move to their own fixture, outside of Xebium.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!
On Jun 28, 2015 5:50 PM, "Arnout Engelen" notifications@github.com wrote:

In src/main/java/com/xebia/incubator/xebium/SeleniumDriverFixture.java
#122 (comment):

@@ -456,6 +524,81 @@ private boolean executeDoCommand(final String methodName, final String[] values)
}
}

  • private String encryptString(String password) { //encrypt exposed passwords or information stub

I think the encryption/decryption methods should move to their own
fixture, outside of Xebium.


Reply to this email directly or view it on GitHub
https://github.com/xebia/Xebium/pull/122/files#r33427425.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants