Adds new nurbs format#107
Open
purepani wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Just to add some details, Attentuation is calculated by a weighted addition of the material attenuation. Also, there was a seemingly unused function that I commented out since I didn't immediately see how to adapt it, and it was unused as far as I could tell. If you could confirm, I can also just remove the function. |
Contributor
Author
|
As a note, I believe this is functional, but I'd test it before merging @MingyeWu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request header
Adds the new nurbs format used by xcat v2. This automatically detects whether the file is the old or new format.
I haven't tested this yet beyond making sure that xcist runs(I haven't looked at the resulting cts), so testing would be appreciated; I might be able to manage that later, but I've been short on time recently, so perhaps not.
Pull request description