chore: replace once_cell with LazyLock, add clippy to CI, misc cleanup

.github/workflows/ci.yml

@@ -11,8 +11,9 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
         with:
-          components: rustfmt
+          components: rustfmt, clippy
       - uses: Swatinem/rust-cache@v2
       - run: cargo fmt --check
       - run: sudo apt-get update && sudo apt-get install -y libgtk-4-dev libadwaita-1-dev
+      - run: cargo clippy -- -D warnings
       - run: cargo test

AGENTS.md

@@ -14,7 +14,7 @@ cargo test
 - **Error handling**: `anyhow::Result` everywhere, `.with_context()` for path-related errors
 - **File I/O**: Always use `write_atomic()` (temp file + rename) for writing .desktop files
 - **GTK state**: `Rc<RefCell<T>>` for shared mutable state in callbacks — this is standard GTK-rs
-- **Lazy statics**: `once_cell::sync::Lazy` for compiled regexes and XDG paths
+- **Lazy statics**: `std::sync::LazyLock` for compiled regexes and XDG paths
 - **Desktop entry format**: INI-like with `[Desktop Entry]` section header, key=value pairs
 - **Startup delay**: Wraps exec as `sh -c 'sleep N && exec CMD'`, parsed back with regex
 - **Field codes**: `%u`, `%U`, `%f`, `%F`, `%i`, `%c`, `%k` are stripped from Exec lines (meaningless for autostart)

CONTRIBUTING.md

@@ -13,7 +13,7 @@ Thanks for your interest in contributing to Onset!
 
 - Open a PR against `main`. CI must pass.
 - Keep changes focused. One fix or feature per PR.
-- Run `cargo fmt` before committing.
+- Run `cargo fmt` and `cargo clippy` before committing.
 
 ## Reporting Issues
 

Cargo.toml

@@ -17,7 +17,6 @@ anyhow = "1.0.100"
 tracing = "0.1.44"
 tracing-subscriber = { version = "0.3.22", features = ["env-filter"] }
 regex = "1.12"
-once_cell = "1.21"
 
 [profile.release]
 lto = true

src/config.rs

@@ -1,8 +1,8 @@
 use std::path::PathBuf;
 
-use once_cell::sync::Lazy;
+use std::sync::LazyLock;
 
-pub static XDG_PATHS: Lazy<XdgPaths> = Lazy::new(XdgPaths::new);
+pub static XDG_PATHS: LazyLock<XdgPaths> = LazyLock::new(XdgPaths::new);
 
 #[derive(Debug, Clone)]
 pub struct XdgPaths {

src/desktop_entry/writer.rs

@@ -3,7 +3,8 @@ use std::io::Write;
 use std::path::Path;
 
 use anyhow::{Context, Result};
-use once_cell::sync::Lazy;
+use std::sync::LazyLock;
+
 use regex::Regex;
 
 use super::parser::escape_value;
@@ -14,7 +15,8 @@ use crate::operations::delay::{unwrap_delay, wrap_with_delay};
 /// Exec line.  These are placeholders for file/URL arguments that are
 /// meaningless in an autostart context where no file or URL is being opened.
 pub(crate) fn strip_field_codes(exec: &str) -> String {
-    static FIELD_CODE_PATTERN: Lazy<Regex> = Lazy::new(|| Regex::new(r"%[uUfFick]").unwrap());
+    static FIELD_CODE_PATTERN: LazyLock<Regex> =
+        LazyLock::new(|| Regex::new(r"%[uUfFick]").unwrap());
     let stripped = FIELD_CODE_PATTERN.replace_all(exec, "");
     stripped.split_whitespace().collect::<Vec<_>>().join(" ")
 }

src/discovery/applications.rs

@@ -81,10 +81,10 @@ fn scan_application_dir(
             continue;
         }
 
-        if let Some(ref try_exec) = desktop_entry.try_exec {
-            if !binary_exists(try_exec) {
-                continue;
-            }
+        if let Some(ref try_exec) = desktop_entry.try_exec
+            && !binary_exists(try_exec)
+        {
+            continue;
         }
 
         seen_ids.insert(id.clone());

src/model/autostart_entry.rs

@@ -37,10 +37,10 @@ impl AutostartEntry {
             return EffectiveState::Disabled;
         }
 
-        if let Some(ref try_exec) = self.desktop_entry.try_exec {
-            if !binary_exists(try_exec) {
-                return EffectiveState::TryExecFailed;
-            }
+        if let Some(ref try_exec) = self.desktop_entry.try_exec
+            && !binary_exists(try_exec)
+        {
+            return EffectiveState::TryExecFailed;
         }
 
         if !self.desktop_entry.only_show_in.is_empty()

src/operations/create.rs

@@ -36,18 +36,9 @@ fn find_unique_path(base_id: &str) -> PathBuf {
         return base_path;
     }
 
-    for i in 1..1000 {
-        let suffixed_path = XDG_PATHS
-            .user_autostart
-            .join(format!("{}_{}.desktop", base_id, i));
-        if !suffixed_path.exists() {
-            return suffixed_path;
-        }
-    }
-
     let timestamp = std::time::SystemTime::now()
         .duration_since(std::time::UNIX_EPOCH)
-        .map(|d| d.as_secs())
+        .map(|d| d.as_millis())
         .unwrap_or(0);
     XDG_PATHS
         .user_autostart

src/operations/delay.rs

@@ -1,8 +1,9 @@
-use once_cell::sync::Lazy;
+use std::sync::LazyLock;
+
 use regex::Regex;
 
-static DELAY_PATTERN: Lazy<Regex> =
-    Lazy::new(|| Regex::new(r"^sh -c 'sleep (\d+) && exec (.+)'$").unwrap());
+static DELAY_PATTERN: LazyLock<Regex> =
+    LazyLock::new(|| Regex::new(r"^sh -c 'sleep (\d+) && exec (.+)'$").unwrap());
 
 pub fn wrap_with_delay(exec: &str, delay_seconds: u32) -> String {
     if delay_seconds == 0 {

src/operations/toggle.rs

@@ -31,16 +31,15 @@ pub fn set_entry_enabled_by_path(path: &Path, enabled: bool) -> Result<()> {
             continue;
         }
 
-        if in_desktop_entry {
-            if let Some((key, _)) = trimmed.split_once('=') {
-                if key.trim() == "Hidden" {
-                    if !enabled {
-                        lines.push("Hidden=true".to_string());
-                        hidden_written = true;
-                    }
-                    continue;
-                }
+        if in_desktop_entry
+            && let Some((key, _)) = trimmed.split_once('=')
+            && key.trim() == "Hidden"
+        {
+            if !enabled {
+                lines.push("Hidden=true".to_string());
+                hidden_written = true;
             }
+            continue;
         }
 
         lines.push(line.to_string());

src/ui/app_chooser.rs

@@ -141,6 +141,7 @@ impl AppChooserDialog {
         let row = adw::ActionRow::builder()
             .title(&app.name)
             .activatable(true)
+            .use_markup(false)
             .build();
 
         if let Some(ref comment) = app.comment {

src/ui/autostart_row.rs

@@ -20,6 +20,7 @@ where
     let row = adw::ActionRow::builder()
         .title(&entry.desktop_entry.name)
         .activatable(true)
+        .use_markup(false)
         .build();
 
     if let Some(ref comment) = entry.desktop_entry.comment {
@@ -143,9 +144,9 @@ where
         .build();
 
     let delete_path = entry.path.clone();
-    let delete_id = entry.id.clone();
+    let delete_name = entry.desktop_entry.name.clone();
     delete_button.connect_clicked(move |_| {
-        on_delete(delete_path.clone(), delete_id.clone());
+        on_delete(delete_path.clone(), delete_name.clone());
     });
 
     row.add_suffix(&delete_button);

src/ui/window.rs

@@ -135,6 +135,7 @@ impl MainWindow {
                     &list_box_clone,
                     &stack_clone,
                     &toast_overlay_clone,
+                    true,
                 );
             });
         }
@@ -275,6 +276,7 @@ impl MainWindow {
         list_box: &gtk4::ListBox,
         stack: &gtk4::Stack,
         toast_overlay: &adw::ToastOverlay,
+        show_toast: bool,
     ) {
         match discover_autostart_entries() {
             Ok(discovered) => {
@@ -333,8 +335,10 @@ impl MainWindow {
                     stack.set_visible_child_name("list");
                 }
 
-                let toast = adw::Toast::new("Entries refreshed");
-                toast_overlay.add_toast(toast);
+                if show_toast {
+                    let toast = adw::Toast::new("Entries refreshed");
+                    toast_overlay.add_toast(toast);
+                }
             }
             Err(e) => {
                 tracing::error!("Failed to refresh entries: {}", e);
@@ -377,6 +381,7 @@ impl MainWindow {
                             &list_box_clone,
                             &stack_clone,
                             &toast_overlay_clone,
+                            false,
                         );
                         let toast = adw::Toast::new(&format!("Added {}", app.name));
                         toast_overlay_clone.add_toast(toast);
@@ -431,6 +436,7 @@ impl MainWindow {
                         &list_box_clone,
                         &stack_clone,
                         &toast_overlay_clone,
+                        false,
                     );
                     let toast = adw::Toast::new(&format!("Created {}", name));
                     toast_overlay_clone.add_toast(toast);
@@ -520,6 +526,7 @@ impl MainWindow {
                                     &list_box_clone,
                                     stack,
                                     &toast_overlay_clone,
+                                    false,
                                 );
                             }
                             let toast = adw::Toast::new(&format!("Updated {}", entry_name));
@@ -540,7 +547,7 @@ impl MainWindow {
 
     fn handle_delete(
         path: PathBuf,
-        id: &str,
+        name: &str,
         entries: &Rc<RefCell<Vec<AutostartEntry>>>,
         list_box: &gtk4::ListBox,
         toast_overlay: &adw::ToastOverlay,
@@ -552,13 +559,13 @@ impl MainWindow {
                 let delete_index = { entries.borrow().iter().position(|e| e.path == path) };
                 entries.borrow_mut().retain(|e| e.path != path);
 
-                if let Some(index) = delete_index {
-                    if let Some(row) = list_box.row_at_index(index as i32) {
-                        list_box.remove(&row);
-                    }
+                if let Some(index) = delete_index
+                    && let Some(row) = list_box.row_at_index(index as i32)
+                {
+                    list_box.remove(&row);
                 }
 
-                let toast = adw::Toast::new(&format!("Deleted {}", id));
+                let toast = adw::Toast::new(&format!("Deleted {}", name));
                 toast_overlay.add_toast(toast);
             }
             Err(e) => {