Skip to content

Add GetUIFloatInherited#254

Merged
korri123 merged 3 commits into
xNVSE:masterfrom
Stentorious:GetUIFloatInherited
May 7, 2026
Merged

Add GetUIFloatInherited#254
korri123 merged 3 commits into
xNVSE:masterfrom
Stentorious:GetUIFloatInherited

Conversation

@Stentorious
Copy link
Copy Markdown
Contributor

Returns the inherited trait value accounting for parent locus behavior.

Can return certain trait values even if the passed tile doesn't have them assigned/

Mainly for use with x/y/depth/systemcolor traits.

Comment thread nvse/nvse/Commands_UI.cpp Outdated
checkLast = next + 1;
}

// Check for inharited trait type
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@Into-The-Rough
Copy link
Copy Markdown
Contributor

try to avoid whitespace/line ending changes in the same commit as other ones for review as it makes reviewing harder

@Into-The-Rough
Copy link
Copy Markdown
Contributor

GH is being a cunt. L2307 tab/space issue

@Into-The-Rough
Copy link
Copy Markdown
Contributor

Minor nit/suggestion for getting the trait name

char* traitName = strrchr(subPath, '/') ? strrchr(subPath, '/') + 1 : subPath;

Comment thread nvse/nvse/CommandTable.cpp Outdated
Comment thread nvse/nvse/Commands_UI.cpp Outdated
Comment thread nvse/nvse/Commands_UI.cpp Outdated
Co-authored-by: Kormákur <korri123@gmail.com>
@korri123 korri123 merged commit 68047f8 into xNVSE:master May 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants