fix(file-manager): expose selected-item actions on touch devices - #13
Open
csells wants to merge 2 commits into
Open
fix(file-manager): expose selected-item actions on touch devices#13csells wants to merge 2 commits into
csells wants to merge 2 commits into
Conversation
Author
|
@xMinor-1, when you have a chance, could you please review this mobile File Manager fix? It has been verified on a phone against a live bb installation, and the focused tests, type checks, and build all pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
On mobile, long-pressing a File Manager row started browser drag mode instead of exposing useful actions. Selected files and folders therefore had no discoverable way to rename, move, copy, delete, download, or add to chat.
The interaction now also covers wide coarse-pointer layouts such as landscape phones and tablets.
Verification
npx vitest run test/frontend/menus.test.tsx test/frontend/gallery.test.tsx test/frontend/dragdrop.test.tsx test/frontend/selection.test.tsx --reporter=dot --maxWorkers=2— 66 passednpx vitest run test/frontend/bookmarks.test.tsx --reporter=dot --maxWorkers=2— 16 passednpm run typechecknpm run types:checknpm run build