Very small patch for visibility in NodeResource#76
Open
baszero wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I found a workaround so I don't need get |
Contributor
Author
|
I reopened this pull request as I really think that making those two methods Use Case / Reason:
Example of overridden method in subclassed NodeResource class: Today you can not reuse the NodeResource and just override the getRepositoryPath() method because it is private. I think that both getNode() and getRepoPath() should be made protected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
important methods should be made
protectedinstead ofprivateso that inheritation becomes easy.