Repository navigation
feat: Providing options for initializing git repo on project creation - #2620
nishu-murmu wants to merge 23 commits into
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 79.68% 79.48% -0.21%
==========================================
Files 138 138
Lines 4111 4118 +7
Branches 943 946 +3
==========================================
- Hits 3276 3273 -3
- Misses 737 745 +8
- Partials 98 100 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: fkatsuhiro <113022468+fkatsuhiro@users.noreply.github.com>
fkatsuhiro
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@PatrykKuniczak can you review this? |
aklinker1
left a comment
There was a problem hiding this comment.
Most init commands don't setup a git repo. What if the computer doesn't have git installed? What if they use a different vcs? Can you provide more details on why you want to add this? Can you point to other packges/frameworks that do create a git repo without asking?
|
Lot of popular frameworks like I don't know, I tried using And people using WXT framework, which requires things like npm and all, it's hardly unlikely that git won't be in the system (we can show a warning while implementing this feature??) |
Yeah, it's standard also in new projects created via JetBrains IDE. I think good idea is skip init when git isn't present. |
|
@PatrykKuniczak @aklinker1 Implemented this new feature, where we're asking whether you want to initialize git repo or not? |
Yeah, let's do it. |
I was saying I've already implemented it, Please review it 😓 |
I understood it, you want to implement it. Because you've placed "?" at the end. I'll take a look on that on free time, because i'm in work right now. |
|
@nishu-murmu Don't use "fix" in title, if you're adding new feature. |
Co-authored-by: Patryk Kuniczak <p.kuniczak@gmail.com>
|
|
||
| // Asks whether require git initialized or not? | ||
| const requireGitInitialized = | ||
| options.requireGit ?? |
There was a problem hiding this comment.
requireGit need to be null to show confirm(), when this could happened?
I can reproduce it only when i set it in line 56 to null
options.requireGit = null!;
There's an real example. where user will see that confirm()?
There was a problem hiding this comment.
That requireGit is one of options for wxt init cli command.
There was a problem hiding this comment.
That
requireGitis one of options for wxt init cli command.
Yeah, i know, but there's true by default, and if you put --no-git then it's false.
There was a problem hiding this comment.
@nishu-murmu What do you think, about message above?
Let's go finally finish this PR
This maybe because you ran wxt init from packages/wxt folder, this will run the local wxt command that's why it is showing that version thing. |
You've provided "cd into packages/wxt." in first step ... Sorry for edit of your message, miss click :( |
|
@nishu-murmu Let's try to be more active on Discord. |




Overview
On
commands.tsfile added new funtionality for initializing the git after the project is cloned.Manual Testing
packages/wxt.bun wxt init(git the directory nametestso it wont conflict).git statusRelated Issue
This PR closes #2603