SimplificationConstantPropogationTest#40
Open
Simone-vanZyl wants to merge 68 commits intowvisser:masterfrom
Simone-vanZyl:simplification
Open
SimplificationConstantPropogationTest#40Simone-vanZyl wants to merge 68 commits intowvisser:masterfrom Simone-vanZyl:simplification
Simone-vanZyl wants to merge 68 commits intowvisser:masterfrom
Simone-vanZyl:simplification
Conversation
…l/green into ConstantPropagation
Zhunaidm
reviewed
Aug 14, 2018
| int prev = 0; | ||
|
|
||
| switch (operator) { | ||
| case GT: |
There was a problem hiding this comment.
Please fix the style of this switch case.
Zhunaidm
reviewed
Aug 14, 2018
| ConstantPropogationVisitor propogationVisitor = | ||
| new ConstantPropogationVisitor(var_map); | ||
| expression.accept(propogationVisitor); | ||
| //log.log(Level.FINEST, "\n__getExpression__\n " + |
Zhunaidm
suggested changes
Aug 14, 2018
Zhunaidm
left a comment
Zhunaidm
left a comment
There was a problem hiding this comment.
Cool, so there's a ton of unused code. Please remove unused code other than the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Simplification added. Only 5 of the 9 cases run. The 4 cases that fail have been commented out as explained in README.md. Thanks!
@PhillipVH
@Monkleys
@Zhunaid
@steynvl