Skip to content

Maybe solved that windows specific problem #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bofm wants to merge 1 commit into from
Closed

Maybe solved that windows specific problem #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions repls/subprocess_repl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import subprocess
import os
import io
import sys
from .repl import Repl
import signal
Expand Down Expand Up @@ -218,16 +219,15 @@ def read_bytes(self):
else:
# this is windows specific problem, that you cannot tell if there
# are more bytes ready, so we read only 1 at a times

while True:
byte = self.popen.stdout.read(1)
if byte == b'\r':
# f'in HACK, for \r\n -> \n translation on windows
# I tried universal_endlines but it was pain and misery! :'(
continue
return byte



## This way it is possible to read more bytes on Windows the same
## way as on POSIX.
with io.open(self.popen.stdout.fileno(), 'rb', closefd=False) as out:
byte = out.read1(4096)
# f'in HACK, for \r\n -> \n translation on windows
# I tried universal_endlines but it was pain and misery! :'(
byte = byte.replace(b'\r', b'')
return byte

def write_bytes(self, bytes):
si = self.popen.stdin
Expand Down