Start args - #64
Merged
Merged
Start args#64
Conversation
- The flag-parsing loop broke out entirely on the first unrecognized flag instead of skipping it, so any custom flag (--analysis-release, --cromwell-version, etc.) placed after an unrecognized passthrough flag leaked straight through to `gcloud compute instances create` and caused "unrecognized arguments" errors. Now unrecognized flags are collected into a GCLOUD_ARGS array and the loop keeps scanning. - Recognized flags only handled space-separated `--flag value` syntax; `--flag=value` caused the next CLI token to be silently swallowed as the value instead. Long options are now normalized (`--flag=value` split into `--flag` `value`) before matching, so both forms work. - `-h`/`--help` as the very first argument was treated as the instance name (since it's non-empty) rather than triggering help, only working when passed after the instance name. Now checked up front. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3bJwQWtWCGFQhQSUgJmbG
- debian-11 image family was removed from the debian-cloud project (Debian 11 bullseye's LTS ended 2026-08-31), causing "imageFamilyViews/debian-11 was not found". Switch to debian-12. - Debian 12's pip enforces PEP 668 (externally-managed-environment), which blocks the startup script's system-wide `pip install requests` as root. Install it via the python3-requests apt package instead, matching the rest of PACKAGES and avoiding the same issue on future Debian releases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3bJwQWtWCGFQhQSUgJmbG
The startup script runs with no controlling TTY (as a GCE startup-script), so debconf's "unable to re-open stdin" warning during apt-get is harmless noise. Set DEBIAN_FRONTEND=noninteractive to quiet it without changing behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3bJwQWtWCGFQhQSUgJmbG
malachig
commented
Sep 11, 2026
malachig
left a comment
malachig
left a comment
Member
Author
There was a problem hiding this comment.
This all seems to be working as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to get
--analysis-releaseand--cromwell-versionoptions working properly forstart.shso that a user can be explicit about the version of the analysis WDLs and Cromwell software that will be automatically installed on the Cromwell VM.Also, additional changes to deal with the recent deprecation of debian-11 google cloud image family and migrate to use of debian-12. Additional work would be needed to migrate to debian-13.